Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 443242

Summary:

Settings menu contains unexternalized strings (TVT)

Product:

[ECD] Orion

Reporter:

Mark Macdonald <mamacdon>

Component:

Client

Assignee:

Project Inbox <orion.client-inbox>

Status:

RESOLVED INVALID

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public

Version:

6.0

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Settings menu unexternalized strings	none

Description Mark Macdonald

2014-09-03 14:00:47 EDT

Created attachment 246691 [details]
Settings menu unexternalized strings

Opened from mega-bug 416060.

1. Click the Settings menu with an Orion UI language pack installed
2. The "Help" and "Report a Bug" entries display in English.

There are preexisting strings ready for these in orion/widgets/nls/messages, so I'm not sure why we are not using those.

Comment 1 Curtis Windatt

2014-09-11 12:54:52 EDT

I'm confused where the strings are coming from.  In pageLinksPlugin.js we register both links as services.  The NLS looks correct there.  Yet any change I make to the name, the nls message or even the URI do not show up when self hosting.  Perhaps somewhere else we have this information hard coded, but I have not been able to find it.

Comment 2 Mark Macdonald

2014-09-12 18:09:44 EDT

Hmm, I don't see the problem anymore. Maybe the language pack was out of date.

However, I did change the "Help" string back to the one in "orion/widgets/nls/messages", since it means we don't have to load the Help message bundle until you actually visit the Help page.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=9bdac93