Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 442761

Summary:

When a DDiagram is locked by using a permission authority some actions are still available

Product:

[Modeling] Sirius

Reporter:

Mickael LANOE <mickael.lanoe>

Component:

Core

Assignee:

Project inbox <sirius.core-inbox>

Status:

CLOSED FIXED

QA Contact:

Belqassim Djafer <belqassim.djafer>

Severity:

normal

Priority:

CC:

alex.lagarde, belqassim.djafer, laurent.fasani, laurent.redor, maxime.porhel, pierre-charles.david

Version:

1.0.0

Keywords:

triaged

Target Milestone:

3.0.0M6

Hardware:

OS:

Windows 7

See Also:

https://git.eclipse.org/r/42497
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c9432acc8ac52333fb8fb1e333556eb093b08788

Whiteboard:

Bug Depends on:

Bug Blocks:

444267, 453994, 456132

Attachments:

Description	Flags
SWTBot test	none
sample permission authority	none
test project	none

Description Mickael LANOE

2014-08-28 03:06:50 EDT

In our use case of Sirius, a DDiagram is locked by using a permission authority. In this case Pin/Unpin, Show/Hide, Filter, Layers and Arrange actions should be disabled.

Comment 1 Maxime Porhel

2014-08-29 05:04:55 EDT

Mickael, could you add a scenario to reproduce the issue. 
It will ease the homologation.

Comment 2 Mickael LANOE

2014-08-29 08:25:11 EDT

Created attachment 246541 [details]
SWTBot test

SWTBot test to show that some tabbar actions should be disabled

Comment 3 Mickael LANOE

2014-09-09 11:20:44 EDT

see https://git.eclipse.org/r/#/c/32454/

Comment 4 Alex Lagarde

2014-09-16 11:05:30 EDT

This issue scope is only the tabbar actions. The 2 GMF Actions from Appearance Page (Underline and Stricke) are considered as out of scope (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=444267)

Comment 5 Alex Lagarde

2014-09-16 11:13:43 EDT

Review suceeded https://git.eclipse.org/r/#/c/32454/

Comment 6 Mickael LANOE

2014-12-02 09:00:24 EST

Gerrit https://git.eclipse.org/r/#/c/33818/  and commit 59fa392fad179ef1d128b9989d906c6f6fc6fe1e

Comment 7 Pierre-Charles David

2014-12-24 04:39:23 EST

Cloned as bug #456132 to backport the fix into Sirius 2.0.x.

Comment 8 Laurent Fasani

2015-01-20 08:52:24 EST

Not completely fixed
When user1 locks the diagram, user2 can still expand the menu and access the ArrangeAll and ArrangeAllBorderNodes commands until user2 click in the diagram.
Note that the other menus like filter or layer and disabled

Comment 9 Maxime Porhel

2015-01-20 09:40:40 EST

See Laurent's comment

Comment 10 Eclipse Genie

2015-02-24 03:55:40 EST

New Gerrit change created: https://git.eclipse.org/r/42497

Comment 11 Eclipse Genie

2015-02-27 07:59:57 EST

Gerrit change https://git.eclipse.org/r/42497 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c9432acc8ac52333fb8fb1e333556eb093b08788

Comment 12 Mickael LANOE

2015-02-27 08:02:51 EST

fix bu commit 1d95dc63c4634a3f607855a31e92ebe392adeb56

Comment 13 Belqassim Djafer

2015-04-10 10:38:41 EDT

Can not verify this issue in a Sirius environment

Comment 14 Belqassim Djafer

2015-05-27 04:55:05 EDT

Created attachment 253820 [details]
sample permission authority

Comment 15 Belqassim Djafer

2015-05-27 04:55:34 EDT

Created attachment 253821 [details]
test project

Comment 16 Belqassim Djafer

2015-05-27 04:57:40 EDT

To validate this issue: 
 . add the sample permission authority plugin project to your workspace
 . launch a runtime
 . add the sample project to the runtime's workspace
 . open 'p0 package entities' diagram.
 . ensure that Pin/Unpin, Show/Hide, Filter, Layers and Arrange actions are disabled.

Comment 17 Belqassim Djafer

2015-05-27 04:58:05 EDT

Verified with Sirius 3.0.0 RC1

Comment 18 Pierre-Charles David

2015-06-24 11:13:00 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.