Bugzilla – Full Text Bug Listing
| Summary: | TVT_PLK Concatenation | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | CDE Administration <cdeadmin> | ||||||||
| Component: | Git | Assignee: | Project Inbox <orion.git-inbox> | ||||||||
| Status: | RESOLVED INVALID | QA Contact: | |||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | baochlin, camle, cjxu, ericchen, keithc, ken_walker, kitlo, kqli, liuxmxm, mamacdon | ||||||||
| Version: | 6.0 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | TVT/DVT4.4:TCT20 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 246368 [details]
21.020.010.jpg
Created attachment 246369 [details]
TCT#20_01.png
<cde:tctdetail> Testcase: 21.020.010 Project: WSW44 Component: Xfer - Orion/Client/Git Priority: 2 Subject: TVT_PLK Concatenation Article ID: 20 Originator: tctbroadcast@localization-star.com Stop Ship: N </cde:tctdetail> (In reply to CDE Administration from comment #0) > <response_by> LocStar at 2014.08.26.05.10.16 </response_by> > Hello. > > Highlighted fragment is concatenation of 2 segments. > Word commit(s) in Polish is context dependent. It's not universal word. Also > we need to change order of words. > > See: > 1 zatwierdzenia do od?o?enia > > To create universal solution we must change order of words to like this: > > Liczba zatwierdze? do od?o?enia: {0}. > > Please create new segment: > > Best regards, > Ewelina > > <response_by> Keith Chuang at 2014.08.26.05.41.38 </response_by> > This article was reassigned from Category:''TVT/Testing,WSW44,Xfer - > Orion/Client/Git''. > > <response_by> Keith Chuang at 2014.08.26.07.01.16 </response_by> > Hi Ewelina, > GSSC confirms this problem is valid but not a concatenated string. > > The root cause is the number is hard coded; hence you are not able to change > the order according to Polish grammar. > > PII Information: > eclipse\plugins\org.eclipse.orion.client.git\web\git\nls\root\gitmessages.js > " commit(s) to push.": " commit(s) to push.", > > We will suggest developers fix the string to be like: > " commit(s) to push.": " {0} commit(s) to push.", where {0} is an integer > > As this is not a major issue, > 1) Would you please lower your severity to 3? > 2) Tell us if you would accept the fix mentioned above? > > Thank you very much. > > Best regards, > Keith > > <response_by> LocStar at 2014.08.26.08.15.16 </response_by> > I will suggest developers fix the string to be like > commit(s) to push: {0}. > > Regards, > Ewelina > > <response_by> Keith Chuang at 2014.08.26.08.39.56 </response_by> > change status to 'Investigate' > > <response_by> Keith Chuang at 2014.08.26.08.41.05 </response_by> > then changing to 'Working'. > > From POL tester: > This is considered a major problem and should be at priority 2. > > <response_by> Keith Chuang at 2014.08.26.08.48.53 </response_by> > change status > > <response_by> Keith Chuang at 2014.08.26.08.54.40 </response_by> > This article was reassigned from Category:''TVT/Testing,WSW44,Inbox''. To sum up: Steps to recreate: - Login Orion - Click Git icon at side bar - Clone a Git repository Problem: 1) This is not a concatenation issue but a hard coded string 2) Suggest to fix the string to be like below in order to avoid grammar issues. " commit(s) to push.": "commit(s) to push: {0}." PII Information: eclipse\plugins\org.eclipse.orion.client.git\web\git\nls\root\gitmessages.js " commit(s) to push.": " commit(s) to push.", Created attachment 246413 [details]
442599_01
The All Repositories view has been removed, which means the problematic string no longer appears in the UI. Fixed the string anyway, since it is still referenced in the code. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c55bd23 |
<response_by> LocStar at 2014.08.26.05.10.16 </response_by> Hello. Highlighted fragment is concatenation of 2 segments. Word commit(s) in Polish is context dependent. It's not universal word. Also we need to change order of words. See: 1 zatwierdzenia do od?o?enia To create universal solution we must change order of words to like this: Liczba zatwierdze? do od?o?enia: {0}. Please create new segment: Best regards, Ewelina <response_by> Keith Chuang at 2014.08.26.05.41.38 </response_by> This article was reassigned from Category:''TVT/Testing,WSW44,Xfer - Orion/Client/Git''. <response_by> Keith Chuang at 2014.08.26.07.01.16 </response_by> Hi Ewelina, GSSC confirms this problem is valid but not a concatenated string. The root cause is the number is hard coded; hence you are not able to change the order according to Polish grammar. PII Information: eclipse\plugins\org.eclipse.orion.client.git\web\git\nls\root\gitmessages.js " commit(s) to push.": " commit(s) to push.", We will suggest developers fix the string to be like: " commit(s) to push.": " {0} commit(s) to push.", where {0} is an integer As this is not a major issue, 1) Would you please lower your severity to 3? 2) Tell us if you would accept the fix mentioned above? Thank you very much. Best regards, Keith <response_by> LocStar at 2014.08.26.08.15.16 </response_by> I will suggest developers fix the string to be like commit(s) to push: {0}. Regards, Ewelina <response_by> Keith Chuang at 2014.08.26.08.39.56 </response_by> change status to 'Investigate' <response_by> Keith Chuang at 2014.08.26.08.41.05 </response_by> then changing to 'Working'. From POL tester: This is considered a major problem and should be at priority 2. <response_by> Keith Chuang at 2014.08.26.08.48.53 </response_by> change status <response_by> Keith Chuang at 2014.08.26.08.54.40 </response_by> This article was reassigned from Category:''TVT/Testing,WSW44,Inbox''.