| Summary: | [WorkingSets] Import as Project should use the same Working Set | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Paul Verest <paul.verest> |
| Component: | UI | Assignee: | Mickael Istria <mistria> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | daniel_megert, iloncar.ml+eclipse, Lars.Vogel, mistria |
| Version: | 4.4 | ||
| Target Milestone: | 4.5 M6 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/39228 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c14722eba0de1fbd567ebd5ce2be64316a3ff6f |
||
| Whiteboard: | |||
|
Description
Paul Verest
Do not make it memeber of a working sets of only immediate project, but all the projects in the hierarchy. :) For example, I use jbosstools playground with gradle projects and I would like to add project from a folder to the working set of the parent projects automatically. CCed mickaelistria (https://github.com/jbosstools/jbosstools-playground/issues/31) Suggested fix: https://git.eclipse.org/r/39228 @Paul @Ivica: I think it would help if you could find some time to look at the suggested code, give it a try, and add some +1 (or -1 if you see bad things) on the Gerrit review. Marking as target for 4.5.M6 as this is an annoying usability issue with a simple patch already available. @Paul @Ivica: I believe it would help to get this patch in if you get the opportunity to give it a try and vote +1 on the Gerrit patch if it fixes the issue for you. Is there a way to test this functionality without downloading and compiling IDE? You'll probably need to download a recent IDE (M5) anyway. Then you clone the eclipse.platform.ui repo, fetch the suggested change from Gerrit, import the modified bundles (org.eclipse.ui.navigator.resources), right-click on project to "Run As > Eclipse application". @Daniel: any chance you can review this soon? When using nested projects and working sets simultaneously, it's a pretty annoying bug; and the fix is simple. (In reply to Mickael Istria from comment #9) > @Daniel: any chance you can review this soon? Done, please Gerrit. Gerrit change https://git.eclipse.org/r/39228 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c14722eba0de1fbd567ebd5ce2be64316a3ff6f Thanks Dani! (In reply to Mickael Istria from comment #12) > Thanks Dani! I suggest to add it to the N&N. Can you provide a Gerrit patch for it, if you agree Michael? IMO, that's not worth being part of the noteworthy. I see this more as a bug fix than as an interesting new feature to advertise about. (In reply to Mickael Istria from comment #14) > IMO, that's not worth being part of the noteworthy. I see this more as a bug > fix than as an interesting new feature to advertise about. +1. |