Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 442459

Summary: [WorkingSets] Import as Project should use the same Working Set
Product: [Eclipse Project] Platform Reporter: Paul Verest <paul.verest>
Component: UIAssignee: Mickael Istria <mistria>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: daniel_megert, iloncar.ml+eclipse, Lars.Vogel, mistria
Version: 4.4   
Target Milestone: 4.5 M6   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/39228
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c14722eba0de1fbd567ebd5ce2be64316a3ff6f
Whiteboard:

Description Paul Verest CLA 2014-08-25 02:29:43 EDT
Since Luna there is nice "Import as Project" option in Project Explorer context menu, when clicking on a folder with .project file.

Project instantly appears in Workspace (without dialog).

Please make newly imported projects by default with the same Working Set as main root project.
Comment 1 Ivica Loncar CLA 2015-01-08 11:23:56 EST
Do not make it memeber of a working sets of only immediate project, but all the projects in the hierarchy. :)

For example, I use jbosstools playground with gradle projects and I would like to add project from a folder to the working set of the parent projects automatically.
Comment 2 Ivica Loncar CLA 2015-01-08 11:25:32 EST
CCed mickaelistria (https://github.com/jbosstools/jbosstools-playground/issues/31)
Comment 3 Mickael Istria CLA 2015-01-08 13:04:23 EST
Suggested fix: https://git.eclipse.org/r/39228
Comment 4 Mickael Istria CLA 2015-01-12 06:05:42 EST
@Paul @Ivica: I think it would help if you could find some time to look at the suggested code, give it a try, and add some +1 (or -1 if you see bad things) on the Gerrit review.
Comment 5 Mickael Istria CLA 2015-02-04 04:03:35 EST
Marking as target for 4.5.M6 as this is an annoying usability issue with a simple patch already available.
Comment 6 Mickael Istria CLA 2015-02-05 03:36:49 EST
@Paul @Ivica: I believe it would help to get this patch in if you get the opportunity to give it a try and vote +1 on the Gerrit patch if it fixes the issue for you.
Comment 7 Ivica Loncar CLA 2015-02-06 08:55:17 EST
Is there a way to test this functionality without downloading and compiling IDE?
Comment 8 Mickael Istria CLA 2015-02-06 11:06:57 EST
You'll probably need to download a recent IDE (M5) anyway.
Then you clone the eclipse.platform.ui repo, fetch the suggested change from Gerrit, import the modified bundles (org.eclipse.ui.navigator.resources), right-click on project to "Run As > Eclipse application".
Comment 9 Mickael Istria CLA 2015-02-10 11:24:22 EST
@Daniel: any chance you can review this soon? When using nested projects and working sets simultaneously, it's a pretty annoying bug; and the fix is simple.
Comment 10 Dani Megert CLA 2015-02-11 10:09:42 EST
(In reply to Mickael Istria from comment #9)
> @Daniel: any chance you can review this soon?

Done, please Gerrit.
Comment 12 Mickael Istria CLA 2015-02-12 07:14:41 EST
Thanks Dani!
Comment 13 Lars Vogel CLA 2015-02-12 07:30:32 EST
(In reply to Mickael Istria from comment #12)
> Thanks Dani!

I suggest to add it to the N&N. Can you provide a Gerrit patch for it, if you agree Michael?
Comment 14 Mickael Istria CLA 2015-02-12 07:34:12 EST
IMO, that's not worth being part of the noteworthy. I see this more as a bug fix than as an interesting new feature to advertise about.
Comment 15 Dani Megert CLA 2015-02-12 07:53:43 EST
(In reply to Mickael Istria from comment #14)
> IMO, that's not worth being part of the noteworthy. I see this more as a bug
> fix than as an interesting new feature to advertise about.

+1.