Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 442233

Summary:	No intuitive way of dismissing commit filtering
Product:	[ECD] Orion	Reporter:	Maciej Bendkowski <maciej.bendkowski>
Component:	Git	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	6.0
Target Milestone:	7.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Maciej Bendkowski

2014-08-21 05:03:04 EDT

With the new git UI, there's no intuitive way (at least for me) to dismiss a commit filter. I had an author filter set up however couldn't find out how to go back to a full commit list. At first, I was expecting an "x" cancel button somewhere in the filter section. As I couldn't find one, I tried to clear the filter input and clicked somewhere outside the filter section to apply. Again, it didn't help. I had to clear out the author input and hit the magnifier icon.

Comment 1 Silenio Quarti

2014-08-21 16:41:05 EDT

This behavior seems fine to me. The user sets its filtering attributes and hit the search button (or type enter) to apply filtering.  The same is true if the user wants to clear the filtering attributes.

We could add a X button to each input to clear its text, but I do not think we should perform filtering when the X button is hit.

We could add a clear button besides the first input for convenience which clears all fields and perform the request.  The only concern I have with this approach is that the UI gets busier. 

We could perform filtering any time one of the attributes change and the input looses focus (or the panel closes). Kind of unexpected.

We could perform filtering any time one of the attributes change and the user does nothing for a while.  I find this behavior quite annoying.

Any other ideas?

Comment 2 Maciej Bendkowski

2014-08-23 07:09:50 EDT

(In reply to Silenio Quarti from comment #1)
> Any other ideas?

In my humble opinion having an additional "x" button to dismiss all filtering (thus returning to the previous "state") and dropping unnecessary magnifiers from the view, as suggested in bug 442235, would actually make the view more clear. My main point here is that I was expecting a "cancel filtering" behavior. Such buttons are quite popular in similar solutions, e.g. email filters, etc. For that reason, I'm not keen on reinventing the expected behavior here and would simply stick to what's out in other, similar solutions.

Comment 3 Silenio Quarti

2014-08-28 10:34:29 EDT

We added a "Clear" button at the bottom of the search panel to remove a filtering attributes and perform the search. I believe this fixes this issue.