Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 442195

Summary:	Remove ::before and ::after css entries for 'Templates' content assist style
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	Editor	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	9.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2014-08-20 13:27:02 EDT

Looks like perhaps some entries left over from reverting the template collector in bug 441600.

The JS 'Templates' section is being changed to '- Templates -' via the ::before and ::after entries in contentassist.css - which causes test failures locally (view on site) in the JS test suite.

Comment 1 Michael Rennie

2014-08-20 14:03:45 EDT

(In reply to Michael Rennie from comment #0)
> Looks like perhaps some entries left over from reverting the template
> collector in bug 441600.
> 

After looking at the history, the change is not from that.

> The JS 'Templates' section is being changed to '- Templates -' via the
> ::before and ::after entries in contentassist.css - which causes test
> failures locally (view on site) in the JS test suite.

After I cleared the local history a few times the failures went away.

I would still recommend getting rid of the extra '-' style since the Keywords heading is not similarly styled.

Comment 2 Michael Rennie

2015-04-22 15:58:04 EDT

Fixed with:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2c93fa5d86ddf6d04c4e9714921d55b58df5c368

Now all of the styled headings in the assist popup look the same.