Bugzilla – Full Text Bug Listing
| Summary: | JGit Repository instances not closed properly at various places | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Ochmann <michael.ochmann> |
| Component: | Git | Assignee: | Bogdan Gheorghe <gheorghe> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P2 | CC: | pwebster |
| Version: | unspecified | ||
| Target Milestone: | 7.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
https://git.eclipse.org/r/#/c/31959/ "Bug 442154 - Proper closing of Repository instances" https://git.eclipse.org/r/#/c/31960/ "Bug 442154 - Clone should not hold Repository instances" Thanks Michael, another good find! Bogdan can you please review. The second set has been reviewed and is ready to go. The first set needs to be rebased as there are some merge conflicts. Rebased and resolved the conflicts. |
Sometimes the deletion of a project with a git repository fails with an IOException indicating that one of the pack files of the repository is still locked. There is no special sequence of UI interactions that triggers this problem reproducibly, but we quite frequently received reports from users about error messages like "Could not delete /mnt/..../projectriver00/.git/objects/pack" when they tried to delete projects after several fetch/pull/push commands on the corresponding git repositories. Locked pack files usually happen in JGit if Repository#close() is not called properly on Repository instance. Looking into the Orion implementation several jobs like CloneJob, FetchJob, PullJob, PushJob, some handlers (GitCloneHandlerV1, GitConfigHandlerV1, GitRemoteHandlerV1) and GitFileDecorator do not close Repository instances at all, or not inside of a try-finally block, so that these instances can be leaked if a command fails with an exception. I'll provide my patches on Gerrit. With these patches the issue did not occur again on any of our Orion instances. So I'm quite confident that I found all relevant places.