Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 441838

Summary: PreTVT44: Some error messages in esprima.js are not externalized
Product: [ECD] Orion Reporter: Keith Chuang <keithc>
Component: JS ToolsAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED NOT_ECLIPSE QA Contact:
Severity: normal    
Priority: P3 CC: baochlin, keithc, kitlo, mamacdon, Michael_Rennie
Version: 6.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
WSW44.js
none
441838_01 none

Description Keith Chuang CLA 2014-08-15 02:41:35 EDT
Created attachment 246023 [details]
WSW44.js

Build label:
Version 4.4.1 Build ID:  7.0.0.v20140813-1903

Steps to recreate problem:
Log in the Orion
Click Editor icon at side bar
Create a Folder
Import WSW44.js
Hover over the error icon at line 1


Problem description:
PreTVT44: Some error messages in esprima.js are not externalized


Expected result:
String(s) marked in red rectangle(s) should be externalized


File Information:
org.eclipse.orion.client.core/web/esprima/esprima.js 

the message block from line 138 to line 171:
 Messages = {
UnexpectedToken: 'Unexpected token %0',
UnexpectedNumber: 'Unexpected number',
UnexpectedString: 'Unexpected string',
UnexpectedIdentifier: 'Unexpected identifier',
UnexpectedReserved: 'Unexpected reserved word',
UnexpectedEOS: 'Unexpected end of input',
NewlineAfterThrow: 'Illegal newline after throw',
InvalidRegExp: 'Invalid regular expression',
UnterminatedRegExp: 'Invalid regular expression: missing /',
InvalidLHSInAssignment: 'Invalid left-hand side in assignment',
InvalidLHSInForIn: 'Invalid left-hand side in for-in',
NoCatchOrFinally: 'Missing catch or finally after try',
UnknownLabel: 'Undefined label \'%0\'',
Redeclaration: '%0 \'%1\' has already been declared',
IllegalContinue: 'Illegal continue statement',
IllegalBreak: 'Illegal break statement',
IllegalReturn: 'Illegal return statement',
StrictModeWith: 'Strict mode code may not include a with statement',
StrictCatchVariable: 'Catch variable may not be eval or arguments in strict mode',
StrictVarName: 'Variable name may not be eval or arguments in strict mode',
StrictParamName: 'Parameter name eval or arguments is not allowed in strict mode',
StrictParamDupe: 'Strict mode function may not have duplicate parameter names',
StrictFunctionName: 'Function name may not be eval or arguments in strict mode',
StrictOctalLiteral: 'Octal literals are not allowed in strict mode.',
StrictDelete: 'Delete of an unqualified identifier in strict mode.',
StrictDuplicateProperty: 'Duplicate data property in object literal not allowed in strict mode',
AccessorDataProperty: 'Object literal may not have data and accessor property with the same name',
AccessorGetSet: 'Object literal may not have multiple get/set accessors with the same name',
StrictLHSAssignment: 'Assignment to eval or arguments is not allowed in strict mode',
StrictLHSPostfix: 'Postfix increment/decrement may not have eval or arguments operand in strict mode',
StrictLHSPrefix: 'Prefix increment/decrement may not have eval or arguments operand in strict mode',
StrictReservedWord: 'Use of future reserved word in strict mode'
};
Comment 1 Keith Chuang CLA 2014-08-15 02:42:28 EDT
Created attachment 246024 [details]
441838_01
Comment 2 Michael Rennie CLA 2014-08-15 09:29:48 EDT
The errors are coming from the 3rd party parser we use. I opened a bug against them to allow the errors to be translated: https://code.google.com/p/esprima/issues/detail?id=578.
Comment 3 Michael Rennie CLA 2014-11-24 10:35:00 EST
I'm closing this not_eclipse, since Esprima would have to NLS their own messages.