Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 441599

Summary: Make it clear org.eclipse.sirius.sample.ecore.design is only meant to be used by our tests
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: RelengAssignee: Project Inbox <sirius.releng-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: esteban.dugueperoux
Version: 1.0.0Keywords: triaged
Target Milestone: 2.0.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Pierre-Charles David CLA 2014-08-12 10:39:48 EDT
The example Ecore modeler in org.eclipse.sirius.sample.ecore.design was initialy designed as a functional (though basic) Ecore modeler and example for Viewpoint/Sirius. It has also been used (and modified) extensively as convenient fixture for our automated tests suites.

The first role (functional Ecore modeler) is now much better served by Ecore Tools 2.0. The second role is still useful (and needed), so we can not simply remove the plug-in. However having both installable can be very confusing (the Viewpoints they define use some of the same names).

We must find a way to keep the code of this modeler so that the tests that use is still work, while making it "impossible" for an end-user not interested in running the tests to have it installed in its environement, and if this happens, make it clear that it is distinct from Ecore Tools.

Proposed solution:
1. rename the plug-in into org.eclipse.sirius.tests.sample.ecore.design. The org.eclipse.sirius.tests.sample namespace is used by other sample metamodels which are only used by our automated tests. It is distinct from the org.eclipse.sirius.sample namespace, which is for example modelers that end-users are encouraged to use and take inspiration from.
2. move the plug-in into the org.eclipse.sirius.tests.feature feature, instead of the current org.eclipse.sirius.samples one.
3. make sure the plug-in is not published in the simrel repos, in the marketplace, in pre-packaged bundles, etc. but only available in the full update-site, in a category clearly labeled as "Test Fixtures" or something like that.
Comment 1 Pierre-Charles David CLA 2014-10-01 03:41:33 EDT
As part of bug #441483, this modeler has been moved out of the "samples" features and into the oes.tests feature, which is published in a separate p2 repository,  with little risk for normal users to ever see or install them.

The only task remaining is the renaming, but this will be handled in the context of #441483 (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=441483#c9).
Comment 2 Pierre-Charles David CLA 2014-10-27 06:52:07 EDT
Available in Sirius 2.0.0.