Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 441552

Summary:	Docker Terminal: Wrong parsing of Docker server response with Docker API Version 1.13
Product:	[ECD] Orion	Reporter:	Roger Kilian-Kehr <rkiliankehr>
Component:	Docker	Assignee:	Project Inbox <orion.server-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	ahunter.eclipse, rkiliankehr
Version:	6.0
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Roger Kilian-Kehr

2014-08-12 02:23:58 EDT

Running Orion 6.0 and Stable Build 20140728 against Docker Server API Version 1.13 does not work and the Terminal doesn't come up.

Reason is most likely a change in the corresponding Docker Server API.

Issue: in DockerServer.java in method getDockerContainer() the following if does not work

} else if (jsonObject.has(DockerContainer.ID.toUpperCase())) {
  // 1.7 API has ID rather than Id

since the JSON response from the Docker server contains the key 'Id' instead of 'ID'. 

Hence, the code should be made safe against the specific version of the Docker API by, e.g. checking for both 'Id' and 'ID'.

I did not check which other Docker API versions are affected.

Comment 1 Anthony Hunter

2015-01-20 15:55:55 EST

We have removed the terminal feature from Orion 8.0, see Bug 457990 for full details.