Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 441482

Summary:

PreTVT44: Unexternalized strings found when deploy the project

Product:

[ECD] Orion

Reporter:

Baochuan Lin <baochlin>

Component:

Editor

Assignee:

Mark Macdonald <mamacdon>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

baochlin, curtis.windatt.public, keithc, kitlo, mamacdon, Szymon.Brandys

Version:

6.0

Target Milestone:

7.0

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Set up your Cloud. Go to Settings	none
The "OK" button	none
441482_01	none
441482_02	none

Description Baochuan Lin

2014-08-11 03:34:54 EDT

Created attachment 245863 [details]
Set up your Cloud. Go to Settings

Steps to recreate problem:
1、Log in the Orion(https://orionhub.org)
2、Click Editor icon from the left side panel
3、Click File -> New -> Project -> Basic
4、Input "test" into name field and click Submit button
5、Click Deploy button

Problem Description:
The "OK" button on the panel and message "Set up your Cloud. Go to Settings" are not externalized.

Comment 1 Baochuan Lin

2014-08-11 03:35:32 EDT

Created attachment 245864 [details]
The  "OK" button

Comment 2 Curtis Windatt

2014-08-20 17:13:03 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f9a6c2f4ee62d452bc39e991927383530ca619f2

This fixes the strings in deploy.js.  I was not able to test all of them, so I'm cc'ing Szymon to make him aware I've made changes.

The OK button in the dialog belongs to another js file so I will work on that in a separate commit.

Comment 3 Keith Chuang

2014-09-09 06:24:03 EDT

(In reply to Curtis Windatt from comment #2)
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=f9a6c2f4ee62d452bc39e991927383530ca619f2
> 
> This fixes the strings in deploy.js.  I was not able to test all of them, so
> I'm cc'ing Szymon to make him aware I've made changes.
> 
> The OK button in the dialog belongs to another js file so I will work on
> that in a separate commit.


Verified in 7.0.0.v20140907-0230, please

1) Investigate why "Set up your Cloud. Go to Settings." is not yet externalized. 
PII Information:
eclipse\plugins\org.eclipse.orion.client.cf\web\cfui\nls\root\messages.js
'deploy.setUpYourCloud':'Set up your Cloud. Go to [Settings](${0}).',


2) Confirm if the vanished "OK" button is UI change.

Comment 4 Keith Chuang

2014-09-09 06:24:34 EDT

Created attachment 246866 [details]
441482_01

Comment 5 Keith Chuang

2014-09-09 06:24:55 EDT

Created attachment 246867 [details]
441482_02

Comment 6 Mark Macdonald

2014-09-09 10:37:02 EDT

(In reply to Keith Chuang from comment #3)
> 
> Verified in 7.0.0.v20140907-0230, please
> 
> 1) Investigate why "Set up your Cloud. Go to Settings." is not yet
> externalized. 

Fixed:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f5d5c43

> 2) Confirm if the vanished "OK" button is UI change.

No -- this looks like a defect. If it is reproducible, can you please open a defect here: https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Orion&component=Deployment&version=6.0 and provide some additional info:

* Are you using orion.eclipse.org or a different server?
* What browser are you running?
* What language pack(s) do you have installed?

Marking this bug as FIXED.

Comment 7 Keith Chuang

2014-09-10 09:51:36 EDT

(In reply to Mark Macdonald from comment #6)
> (In reply to Keith Chuang from comment #3)
> > 
> > Verified in 7.0.0.v20140907-0230, please
> > 
> > 1) Investigate why "Set up your Cloud. Go to Settings." is not yet
> > externalized. 
> 
> Fixed:
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=f5d5c43
I'm not able to reproduce the string with the latest Orion build. Would you please investigate?


> 
> > 2) Confirm if the vanished "OK" button is UI change.
> 
> No -- this looks like a defect. If it is reproducible, can you please open a
> defect here:
> https://bugs.eclipse.org/bugs/enter_bug.
> cgi?product=Orion&component=Deployment&version=6.0 and provide some
> additional info:
> 
> * Are you using orion.eclipse.org or a different server?
> * What browser are you running?
> * What language pack(s) do you have installed?
bug 443706 is opened per request.

> 
> Marking this bug as FIXED.

Comment 8 Baochuan Lin

2014-09-10 09:59:18 EDT

Hi Mark.

We are not able to reproduce the string ""Set up your Cloud. Go to Settings." with the latest Orion build. Would you please investigate?
Reopen it. Thanks.

Comment 9 Mark Macdonald

2014-09-10 11:22:27 EDT

(In reply to Baochuan Lin from comment #8)
> We are not able to reproduce the string ""Set up your Cloud. Go to
> Settings." with the latest Orion build. Would you please investigate?
> Reopen it. Thanks.

In the pseudo-language pack, the string is:

> [G\'Ｓｅｔ ｕｐ ｙｏｕｒ Ｃｌｏｕd. Go to [Settings]([${0}]).İı｜]

after inserting the URL, it is:

> [G'Ｓｅｔ ｕｐ ｙｏｕｒ Ｃｌｏｕd. Go to [Settings]([http://localhost:8080/settings/settings.html#,category=cloud]).İı｜]

Note the outer [] -- since this string gets put into an error message, the page tries to parse it as Markdown. In Markdown format, [] indicates a link. Therefore the page tries to parse the crud inside the outer [] as a URL, which it is not. The entire message gets rejected as invalid, and is never shown.

Comment 10 Mark Macdonald

2014-09-10 12:14:48 EDT

I fixed the Orion UI so that it shows the message as plain text when it fails to parse as Markdown. This means you will see the "G'Ｓｅｔ ｕｐ ｙｏｕｒ Ｃｌｏｕd. .." message, but it will not appear with a clickable link. Hopefully that will be enough to verify this defect.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bcb2906


The approach used by the pseudo-language pack to generate message values is problematic when the message must have a strict format (like Markdown). Not really sure what to do about that. The part that replaces ${0} parameters with [${0}] is especially problematic, since it produces an invalid URL when we're trying to insert a URL there.