Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 441425

Summary: [ToolBar] Javascript error if Toolbar gets disabled in IE8
Product: [RT] RAP Reporter: Michael Fröschen <michael.froeschen>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P2 CC: ivan, mknauer, tbuschto
Version: 2.3   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: sr231
Attachments:
Description Flags
Project to reproduce the problem none

Description Michael Fröschen CLA 2014-08-08 09:08:09 EDT
Created attachment 245836 [details]
Project to reproduce the problem

A Javascript error occurs in IE8 if a Section has a Toolbar as Textclient and that section gets disabled.

I have attached an example Project to reproduce this problem.

Just launch the Application, open it in IE8 and click the "Disable" Button.
Comment 1 Michael Fröschen CLA 2014-08-08 09:27:57 EDT
Looks like disabling the toolbar is enough to reproduce this problem
Comment 2 Ivan Furnadjiev CLA 2014-08-08 09:57:12 EDT
It's also reproducible with our Controls Demo [1] by clicking on "Enabled" checkbox. Unfortunately, the IE7/8 support will be discontinied in the upcomming 3.0 RAP version (related JavaScript code has been already removed from master). I can't garantee that it will be fixed (in 2.3 maintanace branch) at all. 
Tim, what do think - is it an easy fix? JavaScript error when disableling the ToolBar:
-----------
Error: Invalid property value.

  Script: {"head":{"requestCounter":3},"operations":[["set","w112",{"enabled":false}]]}
  name: Error
  number: -2146827908
  description: Invalid property value.
  message: Invalid property value.
------------

[1] http://rap.eclipsesource.com/demo/release/controls/#ToolBar
Comment 3 Tim Buschtoens CLA 2014-08-08 10:07:08 EDT
That's a pretty critical error and we do two service releases for 2.3. We should definetly fix that.
Comment 4 Ivan Furnadjiev CLA 2014-08-08 12:40:31 EDT
(In reply to Tim Buschtoens from comment #3)
> That's a pretty critical error and we do two service releases for 2.3. We
> should definetly fix that.

This error is probably related again to not supported "inherit" in IE8.
Comment 5 Ivan Furnadjiev CLA 2014-08-11 04:59:37 EDT
List is also crashing in the same way - reproducible with Controls Demo -> List.
Comment 6 Ivan Furnadjiev CLA 2014-08-11 05:52:08 EDT
Pending change - https://git.eclipse.org/r/#/c/31374/
Comment 7 Ivan Furnadjiev CLA 2014-08-14 10:48:01 EDT
Fixed in 2.3-maintenance branch with change https://git.eclipse.org/r/31374.