Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 441336

Summary: Discarding an empty set of changes results in a mute NPE
Product: [ECD] Orion Reporter: Maciej Bendkowski <maciej.bendkowski>
Component: ClientAssignee: Eric Moffatt <emoffatt>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: ahunter.eclipse, grant_gayed
Version: 6.0   
Target Milestone: 10.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Maciej Bendkowski CLA 2014-08-07 07:02:24 EDT 
Navigate to the git repository view and hit "Discard" on an empty set of changes. You're going to be prompted. Hit "OK" and witness.. nothing. The underlying server request resulted in a NPE which was not handled on the UI.
Comment 1 Anthony Hunter CLA 2015-05-08 09:31:54 EDT 
The error 500 is hidden from the UI, but you can see if you bring up the developer console.
Comment 2 Eric Moffatt CLA 2015-09-28 13:24:59 EDT 
Fixed with this commit:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e8a1d7209ad0a94a6956a3b53354fe76b4435bad

We now apply the same logic as we do to patches...give a warning banner if nothing is selected...