Bugzilla – Full Text Bug Listing
| Summary: | Implement extend operation for binary transitive closure | ||
|---|---|---|---|
| Product: | [Modeling] Viatra | Reporter: | Marton Bur <marton.bur> |
| Component: | Query | Assignee: | Zoltan Ujhelyi <zoltan.ujhelyi> |
| Status: | RESOLVED FIXED | QA Contact: | Istvan Rath <istvanrath> |
| Severity: | normal | ||
| Priority: | P3 | CC: | balazs.grill, zoltan.ujhelyi |
| Version: | 1.2.0 | ||
| Target Milestone: | 1.7.0M3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/100022 https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=483086b4a63feb8a4e521fdf89c67c37e5a29bd9 https://git.eclipse.org/r/100042 https://git.eclipse.org/r/100041 https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=a03f56e68fbc784111b1606ef31389269380d7c6 https://git.eclipse.org/r/100117 https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=9ff6787cdf47d92c2913fc37072abc0580319d33 |
||
| Whiteboard: | localsearch | ||
|
Description
Marton Bur
It is also desired to have operations that are carrying out the same task, but one of the implementations use the available base index, while the other does not. The operations required should be added, and the planner should be capable of selecting between the operation types in an appropriate way. Here I'd like to ask for advice in order to implement the IterateOver[EClass|EDataType|EStructuralFeature]Instances search operations (which are _not_ using the base index) with the same constraints as I did in https://bugs.eclipse.org/bugs/show_bug.cgi?id=479493#c1 So, how do you think these operations should be initialized to be able to enumerate the possible model element candidates, what modifications can I make in other components? Replaced target milestone from incquery with VIATRA Postponed. (In reply to Marton Bur from comment #0) > During the implementation of the POperation to ISearchOperation compiler the > following ISearchOperations are needed, but not implemented yet: > - Instance of check to EDataType > - Eval as a check operation > - Binary transitive closure as extend operation Balázs, haven't you implemented these operations (or made sure they are not required) for 1.3? (In reply to Zoltan Ujhelyi from comment #6) > (In reply to Marton Bur from comment #0) > > During the implementation of the POperation to ISearchOperation compiler the > > following ISearchOperations are needed, but not implemented yet: > > - Instance of check to EDataType > > - Eval as a check operation > > - Binary transitive closure as extend operation > > Balázs, haven't you implemented these operations (or made sure they are not > required) for 1.3? I've indeed implemented Eval check operation for https://bugs.eclipse.org/bugs/show_bug.cgi?id=496548. There is also an InstanceOfDataTypeCheck implementation made by you as I see. The transitive closure extend is missing. I believe the POperationCompiler should throw an exception if a plan would require extending through transitive closure, though there is no test case for this scenario yet. Thanks for the information; I have updated the summary to make sure it is up-to-date (and make sure we will not open duplicate tasks unnecessarily :) ). Postponed to 1.5 Postponed. New Gerrit change created: https://git.eclipse.org/r/100022 Gerrit change https://git.eclipse.org/r/100022 was merged to [master]. Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=483086b4a63feb8a4e521fdf89c67c37e5a29bd9 New Gerrit change created: https://git.eclipse.org/r/100042 New Gerrit change created: https://git.eclipse.org/r/100041 Gerrit change https://git.eclipse.org/r/100041 was merged to [master]. Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=a03f56e68fbc784111b1606ef31389269380d7c6 New Gerrit change created: https://git.eclipse.org/r/100117 Gerrit change https://git.eclipse.org/r/100042 was merged to [master]. Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=9ff6787cdf47d92c2913fc37072abc0580319d33 Transitive closure node was added in master; the incremental transitive closure algorithm from base was not used because of missing support for cache lifecycle management. |