Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 440892

Summary:	Compare js unit test failed in Safari.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	5.0
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2014-07-31 09:38:52 EDT

The Compare js unit test failed in Safari.

Comment 1 libing wang

2014-07-31 09:58:39 EDT

Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b9cf88e6ccee6f53e730e66d587ce0cd1d1db9e6.

Rerun the uiTests.html in Chrome, FireFox, IE10, Safari in Mac and Safari in Windows. All browsers succeeded the test.

Also run the "compare with each other" and replace mode in search, they all use jsDiff and saw no issues.



The reason was that Safari somehow splits a string by pattern /^/m, leaving an empty string at the end of the result. All other browsers do not.

For instance:
"1\n2\n".split(/^/m);

Result in Chrome:
["1", "2"]

Result in Safari(6 and 5)
["1", "2", ""]