Bugzilla – Full Text Bug Listing
| Summary: | "View on site" page does not load | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Rennie <Michael_Rennie> |
| Component: | Client | Assignee: | Michael Rennie <Michael_Rennie> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | ken_walker, mamacdon |
| Version: | 6.0 | ||
| Target Milestone: | 7.0 | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
At orion.eclipse.org it is loading for me. Just started my site. (In reply to Ken Walker from comment #1) > At orion.eclipse.org it is loading for me. Just started my site. It's the "View on Site" page that is broken here, the Sites page linked from the side menu is fine. Here is the trace from a target:
"TypeError: undefined is not a function
at TableTree._generateRow (http://mrennie-target.orion.eclipse.org:8080/orion/webui/treetable.js:158:19)
at TableTree._generateChildren (http://mrennie-target.orion.eclipse.org:8080/orion/webui/treetable.js:137:10)
at TableTree._generate (http://mrennie-target.orion.eclipse.org:8080/orion/webui/treetable.js:123:10)
at http://mrennie-target.orion.eclipse.org:8080/orion/webui/treetable.js:88:12
at http://mrennie-target.orion.eclipse.org:8080/orion/sites/viewOnSiteTree.js:182:7
at settleDeferred (http://mrennie-target.orion.eclipse.org:8080/orion/Deferred.js:70:28)
at notify (http://mrennie-target.orion.eclipse.org:8080/orion/Deferred.js:144:18)
at MutationObserver.run (http://mrennie-target.orion.eclipse.org:8080/orion/Deferred.js:28:13)"
(In reply to Michael Rennie from comment #3) Looks like it was this commit that broke it: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b82f95f771629471acfcb8ae45aaa8d16b31c08d the reason being that the sites and viewOnSIte renders don't have updateExpandVisuals implementations in them (since they have no expansion) Pushed update to the site(s) renderers to add the stub updateExpandVisuals function and added checks in the tree table to ensure the set renderer has the function before calling it: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1f4df46091445f02e33b5512cad6612891ed2498 |
Steps: 1. select org.eclipse.orion.client/bundles/org.eclipse.orion.client.javascript/web/js-tests/javascript/JsMochaSuite.html 2. popup menu > Open Related > View On Site 3. the resulting sites page is blank Seems there is an exception while trying to load the page: "TypeError: undefined is not a function at h._generateRow (https://orion.eclipse.org/sites/view.js:1257:233) at h._generateChildren (https://orion.eclipse.org/sites/view.js:1256:387) at h._generate (https://orion.eclipse.org/sites/view.js:1256:105) at https://orion.eclipse.org/sites/view.js:1254:427 at https://orion.eclipse.org/sites/view.js:1379:239 at a (https://orion.eclipse.org/sites/view.js:712:456) at MutationObserver.f (https://orion.eclipse.org/sites/view.js:712:224)"