Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 440743

Summary:	Closing the editing session should not add a new ResourceSetSync
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Core	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	triaged
Version:	unspecified
Target Milestone:	2.0.0
Hardware:	PC
OS:	Windows NT
Whiteboard:	flash

Description Maxime Porhel

2014-07-30 06:07:42 EDT

When an editing session is closed in reaction of its corresponding session closing, it installs a new ResourceSetSync which adds a new EditingSessionWorkspaceListener (see default backends). 

This comes from RestoreToLastSavePointListener and SaveSessionWhenNoDialectEditorsListner which in unregister() try to remove themselves from the ResourceSetSyn clients, but this one has already been removed from the editing domain and the getOrInstall method recreates a new one.

Comment 1 Maxime Porhel

2014-07-30 06:12:35 EDT

See https://git.eclipse.org/r/#/c/30718/

Comment 2 Maxime Porhel

2014-08-04 10:25:16 EDT

Corrected on master by commit 94f00e509b14fac9beb60a0e9a274fc9e3886065

Comment 3 Maxime Porhel

2014-08-04 10:25:29 EDT

See previous comment

Comment 4 Pierre-Charles David

2014-10-27 06:51:58 EDT

Available in Sirius 2.0.0.