| Summary: | content assist width should leave space for vertical scrollbar | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | Client | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | curtis.windatt.public | ||||
| Version: | 6.0 | ||||||
| Target Milestone: | 7.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 426012 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Thought this would be an easy change but no luck. An easy workaround would be to bring the minWidth of the dialog closer to the maxWidth. This would leave room in the md editor without affecting the JS editor (which almost always goes past the max width). You can increase the width of the parent node: this.parentNode.style.width = (this.parentNode.offsetWidth + 20) + "px"; //$NON-NLS-0 However, this has to be done somewhere the offsetWidth has already been calculated, but not in show or position where it will be called multiple times. Furthermore, it does not account for the base min/maxWidth of the content assist, meaning it could outside the 70-350px default range. As a side note, not all OS have the same scrollbar width, so this would waste some space on MacOS. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b437167a841689ed992a7c0465c08b3c9e8ff2c9 Fixed in master Resize attribute is not support in IE. This was actually fixed under Bug 426012. |
Created attachment 245450 [details] screenshot Screenshot is attached. It shows two content assist items whose strings are not particularly long but are being chopped off by the window's vertical scrollbar. If the scrollbar is not there then they fit the window width perfectly, but the window measurement should not assume an invisible scrollbar, especially since the content assist window height is constrained and therefore will need to show this scrollbar often.