Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 440503

Summary: [test] Move org.eclipse.jdt.core.tests.* projects to 1.6 compliance level
Product: [Eclipse Project] JDT Reporter: Jay Arthanareeswaran <jarthana>
Component: CoreAssignee: Jay Arthanareeswaran <jarthana>
Status: VERIFIED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: david_williams, manoj.palat, melbeltagy, sptaszkiewicz, stephan.herrmann
Version: 4.4   
Target Milestone: 4.5 M6   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Jay Arthanareeswaran CLA 2014-07-28 00:59:43 EDT
The core bundles themselves have moved to 1.6 and I don't think we need to keep the tests still at 1.4. Note, the BREE should also be adjusted in the manifest files.
Comment 1 David Williams CLA 2014-07-28 01:40:36 EDT
I know I'm pretty "old-school" on this ... but if the bundles themselves, in isolation, don't need 1.6, I'd see no reason to change the BREE. But ... I am not familiar with any of the specific bundles and do not run the tests in my workspace, so would be "the last to know". 

Only down side I know is if you pick the test project and say "run as Junit test plugin" the default settings in the launcher will assume the BREE of the test plugin ("1.4"), and you have to go in and manually change that to 1.6 (but ... you could also "share" a launcher, that would run them correctly?) 

And, naturally, if you were really making use of "1.6" language features, such as to use generics in the tests, then that'd be a good reason to move up. (I did not get that impression, but maybe that's that you meant?)
Comment 2 Jay Arthanareeswaran CLA 2014-07-28 01:51:24 EDT
(In reply to David Williams from comment #1)
> And, naturally, if you were really making use of "1.6" language features,
> such as to use generics in the tests, then that'd be a good reason to move
> up. (I did not get that impression, but maybe that's that you meant?)

We might end up doing that in future if some of the APIs are made generic and the tests need to be adjusted, but as you guessed right that's not the reason. I just wanted the test projects to be consistent with everything else.
Comment 3 Stephan Herrmann CLA 2014-07-28 03:29:44 EDT
Just the other day I tried to use a foreach loop in a test and was surprised it wasn't accepted :)
Comment 4 Mohamed El-Beltagy CLA 2014-07-28 15:26:26 EDT
JDT/Core FAQ, "Configuring the workspace" section has been updated to reflect the current exact requirement which is including JRE/JDK 1.4.

When this bug is resolved, JRE/JDK 1.4 should be removed again from FAQ page.
Comment 5 Szymon Ptaszkiewicz CLA 2015-03-19 11:12:18 EDT
I think this bug is no longer valid because JDT/Core bundles already moved to 1.7.
Comment 6 Jay Arthanareeswaran CLA 2015-03-20 02:14:42 EDT
Thanks for the note, Szymon, I am marking this as resolved.

*** This bug has been marked as a duplicate of bug 460588 ***
Comment 7 Manoj N Palat CLA 2015-03-20 02:44:29 EDT
Verified for Eclipse 4.5 M6 with build I20150318-2000