Bugzilla – Full Text Bug Listing
| Summary: | Provide easy repository configuration for (non-)Gerrit repositories | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Johannes Dorn <johannes.dorn> |
| Component: | Recommenders | Assignee: | Yasett Acurana <yasett.giselle> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | sewe, yasett.giselle |
| Version: | unspecified | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/67457 https://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/commit/?id=9ef0579fbd666b8f456a98ad79404795081ff75e |
||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Johannes Dorn
(In reply to Johannes Dorn from comment #0) > I am not yet sure how to handle the push URI field. Should we only display > this field when a Gerrit or other Repository is selected? Or is there a > legitimate reason to fetch from and push to separate pure git repositories? > Opinions? Not sure how common it is but fetch over HTTP and push over SSH may be a valid use case; you can at least fetch in environments where every port != 80 is blocked. Classifying as enhancement request. I think this requires some quick UI prototypes.
The simplest implementation would simply turn the current "branch prefix" text widget into a combo widget [1], with two prefixes already in the dropdown list ("refs/for" and "refs/heads").
However, this would not give the user any indication what "refs/for" means, i.e., that it is normally used by Gerrit.
So maybe a variant of Johannes suggestion in comment 0 would be better:
--Branch prefix---
O Standard Git repository (refs/heads)
O Gerrit code review (refs/for)
O Other: [ ]
[1] <http://www.eclipse.org/swt/widgets/>
(In reply to Andreas Sewe from comment #3) > I think this requires some quick UI prototypes. > > The simplest implementation would simply turn the current "branch prefix" > text widget into a combo widget [1], with two prefixes already in the > dropdown list ("refs/for" and "refs/heads"). Hi, I attached three alternatives to help decide what would be more intuitive for the user. I will also send the prototypes to the mailing list, in order to get more feedback from the contributors. Created attachment 259657 [details]
Proposed alternative 'A' for UI enhancement
Created attachment 259658 [details]
Proposed alternative 'B' for UI enhancement
Created attachment 259659 [details]
Proposed alternative 'C' for UI enhancement
Created attachment 259956 [details]
Prototype chosen to implement this enhancement
Hi,
According to the feedback received, I attached the defined prototype for this enhancement.
I will push a first version of the source code later today.
(In reply to Yasett Acurana from comment #8) > I will push a first version of the source code later today. Great. Just remember to push to the maintenance branch. Would be great to have this change in 2.3.1 already, rather than having to wait for 2.4.0 (which will probably be in Neon). New Gerrit change created: https://git.eclipse.org/r/67457 Gerrit change https://git.eclipse.org/r/67457 was merged to [maintenance]. Commit: http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/commit/?id=9ef0579fbd666b8f456a98ad79404795081ff75e (In reply to Eclipse Genie from comment #11) > Gerrit change https://git.eclipse.org/r/67457 was merged to [maintenance]. > Commit: > http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/commit/ > ?id=9ef0579fbd666b8f456a98ad79404795081ff75e Change merged. Will be part of 2.3.1 and our Neon M6 contribution. Thanks for the contribution, Yasett. |