Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 439898

Summary:	o.e.s.ui.tools.internal.views.common.modelingproject.model.ModelingModelProvider should be lower in the stack
Product:	[Modeling] Sirius	Reporter:	Cedric Brun <cedric.brun>
Component:	Core	Assignee:	Pierre-Charles David <pierre-charles.david>
Status:	CLOSED FIXED	QA Contact:	Florian Barbin <florian.barbin>
Severity:	enhancement
Priority:	P3	CC:	alex.lagarde, florian.barbin, laurent.goubet, pierre-charles.david, twolf
Version:	1.0.0	Keywords:	triaged
Target Milestone:	6.0.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/120641 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=79b885cfc61404de12ca713fe82eba6eff8f383b https://bugs.eclipse.org/bugs/show_bug.cgi?id=543420
Whiteboard:

Description Cedric Brun

2014-07-18 10:22:21 EDT

This class can get instantiated and loaded very soon when the workspace try to 
to some operation while keeping the consistency. This might also happen when the user right-click in the workspace when the team operations are initializing themselves.

Looking at its dependencies it could quite easily be lower in the stack: in org.eclipse.sirius itself.

We should probably move it there, that would lower the class loading pressure and avoid potential issues by loading a plugin which depends on the UI because of an extension point which *could* be used without UI.

Comment 1 Laurent Goubet

2014-07-18 10:47:50 EDT

The modelProviders extension point is supposed to be lazy, but there are a few ways to "break" the lazyness, one such example being in Team itself, see bug 439902.

Since the plugins might be activated spuriously, moving the extension as low as possible can only be a good thing.

Comment 2 Alex Lagarde

2014-07-25 08:16:59 EDT

Marking issue as triaged as this is a valid need.

Comment 3 Eclipse Genie

2018-04-03 10:46:29 EDT

New Gerrit change created: https://git.eclipse.org/r/120641

Comment 4 Eclipse Genie

2018-04-12 05:51:31 EDT

Gerrit change https://git.eclipse.org/r/120641 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=79b885cfc61404de12ca713fe82eba6eff8f383b

Comment 5 Pierre-Charles David

2018-04-12 05:51:59 EDT

Fixed. There is nothing to test or validate, this is purely an internal change which moves some code around.

Comment 6 Laurent Redor

2018-06-27 11:55:11 EDT

Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details

Comment 7 Thomas Wolf

2019-01-15 09:54:44 EST

(In reply to Laurent Redor from comment #6)
> Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for
> details

This causes bug 543420 due to an inconsistency with the model provider ID.