Bug 439637

Description Markus Keller 2014-07-15 12:02:44 EDT

Follow-up to bug 430573. Convert lambda to anonymous must also qualify implicit references to 'this' in method invocations or field references iff the same names are also declared in the functional interface (or in a superinterface, see the "comb rule" in JLS8 15.12.1).

package p;

import java.util.function.*;

public class A {
    public static final int CONST = -1;
    A() {
        IntSupplier i = () -> getAsInt();
        
        Predicate<String> p = s -> test(s);
        Predicate<String> p2 = s -> or(true, false);
        Fooable f = () -> CONST;
    }
    
    public int getAsInt() {
        return 7;
    }
    
    boolean test(String s) {
        return s.length() == 7;
    }
    
    public boolean or(boolean a, boolean b) {
        return a || b;
    }
}

@FunctionalInterface
interface Fooable {
    int CONST = 42;
    int foo();
}

We should only qualify references if there's a name conflict. org.eclipse.jdt.internal.corext.fix.CodeStyleFix probably has some helpful implementation hints in CodeStyleVisitor and ThisQualifierVisitor#hasConflict(..).