Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 439365

Summary: [git] Sync button workflow issue with incoming changes
Product: [ECD] Orion Reporter: Anthony Hunter <ahunter.eclipse>
Component: GitAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pwebster, Silenio_Quarti
Version: unspecified   
Target Milestone: 7.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Anthony Hunter CLA 2014-07-10 12:09:23 EDT 
Create a git project in Orion against a Github repo.

Some time later, you will go to the Git Repositories page for the project and automatically see that there are incoming changes. 

Hit the Sync button to bring the changes in.

The result is a git push occurs first and you are prompted for a password. This should not occur, I have no outgoing changes. 

The password prompt additionally does not make sense in the case where I am not actually a member of the Github project.

To resolve you have to enter your userid and password again (or use the fetch and rebase buttons).
Comment 1 Anthony Hunter CLA 2014-09-04 17:07:05 EDT 
Ken mentioned this issue today so I am pointing out this bug I previously raised again. 

The current workflow with the new Sync button on the new Repositories page is still wrong.

When you go to the Git Repositories page for a project you automatically see that there are incoming changes. 

Hit the Sync button to bring the changes in. This is the new simple workflow we want everyone to use. 

The result is a git push occurs first and you are prompted for a password. This should not occur, I have no outgoing changes. 

The password prompt additionally does not make sense in the case where I am not actually a member of the git project and can in fact never push. So as soon as I cancel the dialog the Sync ends.

To resolve you have the fetch and rebase buttons, you cannot use the sync button for this Git project.
Comment 2 Silenio Quarti CLA 2014-09-12 12:45:57 EDT 
Push will only be done if there are outgoing changes.

Fixed
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=9fabb068b9b469f991275faac1281bae474bd9a5