Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 439154

Summary: Product in update is said to be 4.4.0 instead of 4.5.0
Product: [Eclipse Project] Platform Reporter: Szymon Ptaszkiewicz <sptaszkiewicz>
Component: RelengAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: david_williams
Version: 4.4   
Target Milestone: 4.5 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 436736, 439189    
Attachments:
Description Flags
Wrong version during "Check for Updates" none

Description Szymon Ptaszkiewicz CLA 2014-07-08 12:22:32 EDT
Created attachment 244892 [details]
Wrong version during "Check for Updates"

It seems that we still have a reference to 4.4 in the latest I-build. See the attached image for details. There is probably one more place somewhere that needs to be updated in a similar way it was done in bug 436736 comment 19.
Comment 1 David Williams CLA 2014-07-08 16:19:52 EDT
In bug 439153 comment 3 Thanh suggested 

 https://git.eclipse.org/r/29622

for the "version fix". 

But, I rejected that fix ... being a bit fickle about it. 

Primarily, the version THIS bug talks about, or "sees" in update, is not from the 'feature", but from the "product". So there's several spots in "tychobuilder" that need a fix for the "product version". 

Second, it is true the feature will have to be updated at some point, BUT, that really should be done "bottom up". That is, a features version increment depends on the bundles version increments and feature version increments that it contains ... so I would prefer to implement it bottom-up as well. In theory, though unlikely, there might be a day we decide something should be merely "service increase". 

[Lastly, while I doubt I'll get to it anytime soon ... so no need to delay for that reason -- someday we'll have a tool that tells us when a feature should be incremented, and is not.]
Comment 2 David Williams CLA 2014-07-08 16:41:53 EDT
Changing title to better describe issue, as found when updating to build I20140708-0800.
Comment 3 David Williams CLA 2014-07-08 17:04:37 EDT
I've updated all the "products" to be 4.5.0, as well as the update sites ... to be "4.5" for Eclipse, and "releases/mars" for Sim. Release repo. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=9c83103c68bf489f9f712d4aa5050383f05e8cac

As I mentioned, the features will need to be updated too ... but, that needs to be done "bottoms up", depending on when/how other plugins/features are incremented.