Bug 438872

Comment 1 Paul Webster 2014-07-03 14:30:46 EDT

Gerrit review: https://git.eclipse.org/r/29419

PW

Comment 2 Anthony Hunter 2014-07-04 12:12:45 EDT

I pushed your change with the following commit since it looked good:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5be1f06c97532504d568d0bff25e5628d3daa116

I then had to revert your change to egit with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=fbcebf8ed5fe15f58b796e1b227d4515b4444819

I do not know what they did, but I cannot seem to get the latest either 3.4 or 3.4.1 into the target. Seems like they have removed egit 3.4.0. Do you see the same issue Paul?

Comment 3 Paul Webster 2014-07-04 13:41:13 EDT

Thanks for trying Anthony.  I just tried and it worked.

I checked out http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5be1f06c97532504d568d0bff25e5628d3daa116

Then I did the full import from orion.client and orion.server.  Then I went and picked the .target file in Preferences>Plug-in Development>Target Platform.

I got no errors, the target platform loaded, and all of my compile errors are gone.  If I go back to the prefs and double check, it loaded the correct jgit.

<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="slicer" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.jgit" version="3.4.0.201406110918-r"/>
<repository location="http://download.eclipse.org/egit/updates-3.4"/>
</location>

I can't explain why it failed for you.

PW

Comment 4 Anthony Hunter 2014-07-04 15:19:06 EDT

(In reply to Paul Webster from comment #3)
> Thanks for trying Anthony.  I just tried and it worked.

The target file works on my windows 7 machine with Kepler.

When I use Luna GA on both Windows 7 and Linux I get the error.

org.eclipse.core.runtime.CoreException: Problems occurred getting the plug-ins in this container
	at org.eclipse.pde.internal.core.PluginModelManager.getExternalBundles(PluginModelManager.java:604)
	at org.eclipse.pde.internal.core.PluginModelManager.initializeTable(PluginModelManager.java:525)
	at org.eclipse.pde.internal.core.PluginModelManager.targetReloaded(PluginModelManager.java:473)
	at org.eclipse.pde.core.target.LoadTargetDefinitionJob.resetPlatform(LoadTargetDefinitionJob.java:229)
	at org.eclipse.pde.core.target.LoadTargetDefinitionJob.runInWorkspace(LoadTargetDefinitionJob.java:150)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Contains: Unable to locate installable unit org.eclipse.jgit
Contains: Unable to locate installable unit org.eclipse.jgit
Contains: Unable to locate installable unit org.eclipse.jgit
Contains: Unable to locate installable unit org.eclipse.jgit
Contains: Unable to locate installable unit org.eclipse.jgit
Contains: Unable to locate installable unit org.eclipse.jgit

Comment 5 Anthony Hunter 2014-07-04 15:41:34 EDT

I put the eGit 3.4 GA back again, the build works fine.

If I cannot get Luna to work I will revert to Kepler again since the target works there.

Comment 6 Anthony Hunter 2014-07-04 15:53:27 EDT

I tried again and the target magically worked this time. Yea!