Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 438426

Summary:

can solstice theme (via eclipse.org-common.git) be copied to "build.eclipse.org"

Product:

Community

Reporter:

David Williams <david_williams>

Component:

Website

Assignee:

phoenix.ui <phoenix.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

chris.guindon, denis.roy

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
lines missing when browser maximized	none
lines visible when browser restored to normal size (approx 1/4 of screen)	none

Description David Williams

2014-06-27 13:26:11 EDT

As you probably know, we occasionally leave builds on "build" ... until we decide to promote one to "downloads". (This is routine for "Orbit", but more occasional for Eclipse Project builds). 

I was thinking if the solstice theme would be put there, too, (the same, "static HTML" type version) then we've have more of a "wysiwyg" experience between builds and downloads -- useful for "testing" layouts, if nothing else? 

If done, then might be a case where better to include the "meta tag" for robots, which was removed for main sites (for reference, see bug 438274). That is, no need for google searches to return things on "build machine" (no great harm in it ... just more confusing for end-user, probably).

Comment 1 Denis Roy

2014-06-30 09:59:07 EDT

I've updated it.

Comment 2 David Williams

2014-06-30 16:46:24 EDT

Thanks! 

If you want to see an "early version", see 

http://build.eclipse.org/orbit/committers/orbit-I/20140630012243/I20140630012243/

And thought I'd comment on one anomaly, in case it rings any bells ... 

The (large) "table of bundles" is not always displayed correctly. Sometime "lines" are omitted ... and pretty sure I've seen times where the top few cells were omitted. The latter was fixed if I'd scroll all the way down ... and then back up. (but not currently seeing that). 

The "missing lines" seems pretty consistent ... on Firefox at least, haven't check others. AND, its sort of counter intuitive ... if browser is maximized, some will go missing. If I "restore" size to something more normal, then lines appear. I'll attach screen shots, and all this is just FYI ... unless you know its a "well known issue" and how to solve it. I'm assuming (hoping) that it is just that I'm using "old fashioned" HTML attributes for the table, instead of defining its shape and padding, etc., with CSS. So I hope once I fix that, it'll appear more normal, (and compressed). 

For our "old" version, see 
http://build.eclipse.org/orbit/committers/orbit-I/20140607063447/I20140607063447/

Comment 3 David Williams

2014-06-30 16:47:07 EDT

Created attachment 244682 [details]
lines missing when browser maximized

Comment 4 David Williams

2014-06-30 16:47:58 EDT

Created attachment 244683 [details]
lines visible when browser restored to normal size (approx 1/4 of screen)

Comment 5 Christopher Guindon

2014-06-30 16:49:43 EDT

(In reply to David Williams from comment #3)
> Created attachment 244682 [details]
> lines missing when browser maximized

Can you try using the bootstrap tables?

http://getbootstrap.com/css/#tables

<table class="table">

or

<table class="table table-bordered">

I think you are safe to remove border=1

Comment 6 David Williams

2014-06-30 17:33:49 EDT

(In reply to Christopher Guindon from comment #5)
> (In reply to David Williams from comment #3)
> > Created attachment 244682 [details]
> > lines missing when browser maximized
> 
> Can you try using the bootstrap tables?
> 
> http://getbootstrap.com/css/#tables
> 
> <table class="table">
> 
> or
> 
> <table class="table table-bordered">
> 
> I think you are safe to remove border=1

Thanks, I think 
<table class="table table-striped table-condensed">

looks pretty good. I assume this "getbootstrap" library is just something you've incorporated into the theme? So anything I find documented there would "fair game"? 

This solution reminds me of a lesson my father once taught me about making labels for boxes ... if you have trouble making straight lines, then make them extra crooked so no one will think you were trying to make straight lines! :)

Comment 7 Christopher Guindon

2014-06-30 18:27:06 EDT

(In reply to David Williams from comment #6)
> (In reply to Christopher Guindon from comment #5)
> > (In reply to David Williams from comment #3)
> > > Created attachment 244682 [details]
> > > lines missing when browser maximized
> > 
> > Can you try using the bootstrap tables?
> > 
> > http://getbootstrap.com/css/#tables
> > 
> > <table class="table">
> > 
> > or
> > 
> > <table class="table table-bordered">
> > 
> > I think you are safe to remove border=1
> 
> Thanks, I think 
> <table class="table table-striped table-condensed">
> 
> looks pretty good. I assume this "getbootstrap" library is just something
> you've incorporated into the theme? So anything I find documented there
> would "fair game"? 

Yes, the solstice theme is built on top of bootstrap. You should be able to use anything from the documentation. Please open new bugs if a components is not displaying properly. 




> 
> This solution reminds me of a lesson my father once taught me about making
> labels for boxes ... if you have trouble making straight lines, then make
> them extra crooked so no one will think you were trying to make straight
> lines! :)

haha that's a good lesson :)