Bugzilla – Full Text Bug Listing
| Summary: | Reviewing via Gerrit not enabled on org.eclipse.rmf.documentation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Community | Reporter: | Michael Jastram <michael> | ||||||
| Component: | Gerrit | Assignee: | Eclipse Webmaster <webmaster> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | thanh.ha | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Michael Jastram
(In reply to Michael Jastram from comment #0) > My Problem: I have a contributor who just submitted a patch via Gerrit. I > can see the submission, but I cannot review it. I used Gerrit before, there > used to be a "Review" button. Could it be that I am not a reviewer for this > repository? How can I configure this? I tried to add myself as a reviewer, > using the "[+]" link, but Gerrit wouldn't add me (no error message either). > I checked your permissions and they seem correct. The permissions on the repo are also the same as the org.eclipse.rmf.git repo so if you can review in the old repo the new one should work too. Do you have multiple accounts, can you confirm that you are logged in with your committer account? I can see that you were able to push a patch [1] with your account that forged the author field so this tells me your account has the right permissions. Can you provide a screenshot of what you are seeing when you are looking at the patch? > I also noted that the repository does not seem to be associated with the RMF > project yet: I don't see it listed on the project page: > Should not be related. [1] https://git.eclipse.org/r/#/c/29123/ Created attachment 244675 [details]
Screenshot of Gerrit
> Do you have multiple accounts, can you confirm that you are logged in with > your committer account? Well, I have an email-account (michael@jastram.de) and a username-accont (mjastram). However, I could only log in via email. > I can see that you were able to push a patch [1] with your account that > forged the author field so this tells me your account has the right > permissions. Yes, I was playing around. "Cherry Pick" was the only active option. > Can you provide a screenshot of what you are seeing when you are looking at > the patch? I just attached a screenshot. Maybe everything is correct, and I am just to retarded to understand the interface. :-( But I was expecting to have a "Review" button, as before. > [1] https://git.eclipse.org/r/#/c/29123/ Created attachment 244676 [details]
Screenshot of Gerrit (discard previous one)
Looks like you're using the new change screen. In 2.8.x Gerrit's new change screen isn't fully featured and is still in development as far as I know. So I think this maybe be where the confusion is. With the new change screen instead of "Review" there's a "Reply" button at the top. You should be able to vote but at the moment you cannot because the change is in "Abandon" state. But if you look at another Review such as this [1], you should see the usually "Comment" and "Vote" fields. Personally I still use the Old change screen since I feel the New Change screen isn't complete yet. You change change this in your user's preferences. I believe the New Change screen will be default in 2.9. [1] https://git.eclipse.org/r/#/c/29103/ > With the new change screen instead of "Review" there's a "Reply" button at the top.
That's it - I feel stupid (but then again, it's not really intuitive). Anyway, that resolves the issue - thanks a lot.
|