Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 438146

Summary: Starting Site on Orion Hub containing '_' character fails
Product: [ECD] Orion Reporter: Ray Klundt <rayk428>
Component: OrionHubAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon, rayk428
Version: unspecified   
Target Milestone: 6.0 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Error Screenshot none

Description Ray Klundt CLA 2014-06-25 08:27:33 EDT

    
Comment 1 Ray Klundt CLA 2014-06-25 08:28:55 EDT
Two issues - 

1) Site won't start if site name starts with underscore '_'
2) Error message displays encoded html instead of plain message:


Message displayed:
<html> <head> <meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/> <title>Error 500 Server Error</title> </head> <body> <h2>HTTP ERROR: 500</h2> <p>Problem accessing /site/Ray-A. Reason: <pre> Server Error</pre></p> <hr /><i><small>Powered by Jetty://</small></i> </body> </html>
Comment 2 Ray Klundt CLA 2014-06-25 08:29:42 EDT
Created attachment 244512 [details]
Error Screenshot
Comment 3 Ray Klundt CLA 2014-06-25 08:32:22 EDT
... looks to be any site with a '_' character... Site named "1_Test" also failed.

I can get a site to start if I don't use the underscore in the name.
Comment 4 Ray Klundt CLA 2014-06-25 08:34:26 EDT
(In reply to Ray Klundt from comment #1)
 
> 1) Site won't start if site name starts with underscore '_' 

Update - Site won't start if site name CONTAINS an underscore '_'
Comment 5 Mark Macdonald CLA 2014-06-25 11:08:13 EDT
1) Underscore is not a valid character in hostnames. The editor fails to enforce this restriction, so the underscore is saved into your site and causes it to fail at start time.

2) Server wasn't handling the error correctly.
Comment 6 Mark Macdonald CLA 2014-06-25 11:35:24 EDT
Well, I tried (twice) to submit these commits to Gerrit for review, but it just auto-merged them without creating a patch. So I won't be doing that again.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=963bc2c
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=2dcc8f8

marking fixed.