Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 438095

Summary:	Update to ESLint 0.6.2
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public, mamacdon
Version:	6.0
Target Milestone:	7.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:
Bug Depends on:
Bug Blocks:	438320

Description Michael Rennie

2014-06-24 15:22:20 EDT

CQ is here and approved:  https://dev.eclipse.org/ipzilla/show_bug.cgi?id=8390

There are a few API changes to adapt to. But most notably we have to adapt to the removal of jslint support from eslint in 0.6.2. The immediate impact of this change is that the stanzas in JS source files will no longer silence linting errors (they are completely ignored).

One work around for this is the new stanza -> /* eslint-env node */. Note that there is no need for the ':true' bits on the end, just the presence of the global name equals 'true' (leaving it out means 'false'). To help make users aware of this we can add a rule that will flag the use of the jslint stanza and provide a warning like 'jslint is no longer supported, use eslint-env' (or similar).

Comment 1 Michael Rennie

2014-06-26 15:38:59 EDT

Pushed the update to its own branch. We can merge when 7.0 starts:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/log/?h=eslint0.6.2

Comment 2 Michael Rennie

2014-07-02 12:53:00 EDT

Merged the branch with master. I added a new rule for warning about js[L|H]int directives no longer being supported.