Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 438088

Summary:

Switch global lint preference from JSLint to ESLint

Product:

[ECD] Orion

Reporter:

Michael Rennie <Michael_Rennie>

Component:

JS Tools

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, john.arthorne

Version:

6.0

Flags:

curtis.windatt.public: review+

Target Milestone:

6.0 RC2

Hardware:

OS:

Mac OS X

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Michael Rennie

2014-06-24 15:00:29 EDT

As we only use JSLint to validate JSON, there is no reason to keep the preference, since it only adds confusion trying to set global linting options.

More specifically John and I were chatting about if he could just set 'node:true' in that pref and have it behave like the stanzas in all the JS files -> '/* jslint node:true*/'. The confusion arises since that stanza is read and honoured by eslint, so passing that same option into jslint has no effect whatsoever.

Comment 1 John Arthorne

2014-06-24 15:05:19 EDT

Actually what I was looking for is the ability to set a global flag for our current linting tool. So I think it would make sense to change this preference to be the global eslint flags instead of jslint.

Comment 2 Michael Rennie

2014-06-24 15:22:54 EDT

Created attachment 244483 [details]
fix

Since the update to 0.6.2 (bug 438095) will shake up how we create / work with the stanzas, we can add / update the preference for global eslint settings then. But for now we should just get rid of the JSLint pref

Comment 3 Curtis Windatt

2014-06-24 16:41:27 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=82b771f829ba5c83f3c719981f5bf1b0c373913b

I agree, remove the pref for 6.0 to remove any confusion. Fixed in master.