Bugzilla – Full Text Bug Listing
| Summary: | JavaScript Validator - "Switch case fall-through:" unexternalized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Kit Lo <kitlo> | ||||
| Component: | JS Tools | Assignee: | Project Inbox <orion.client-inbox> | ||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Michael_Rennie | ||||
| Version: | 6.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hmm, something seems fishy here, the pref is externalized, here is the entry in the NLS file:
'noFallthrough' : 'Switch case fall-through', //$NON-NLS-0$ //$NON-NLS-1$
and here is its definition:
{id: "validate_no_fallthrough", //$NON-NLS-0$
nameKey: 'noFallthrough', //$NON-NLS-0$
type: "number", //$NON-NLS-0$
defaultValue: error,
options: severities
},
perhaps you need to clear your local storage and refresh?
I don't see the string in this snapshot http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/snapshot/bogTag.zip in this file org.eclipse.orion.client.javascript\web\javascript\nls\root\messages.js Am I looking at the right file? Was the string checked in recently? (In reply to Kit Lo from comment #2) > I don't see the string in this snapshot > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/snapshot/bogTag. > zip in this file > org.eclipse.orion.client.javascript\web\javascript\nls\root\messages.js > > Am I looking at the right file? Was the string checked in recently? It was just added this week (bug 429815). The string does appear in the file: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/tree/bundles/org.eclipse.orion.client.javascript/web/javascript/nls/root/messages.js I guess maybe it didn't make it into that tag? (In reply to Kit Lo from comment #2) > I don't see the string in this snapshot > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/snapshot/bogTag. > zip in this file > org.eclipse.orion.client.javascript\web\javascript\nls\root\messages.js > > Am I looking at the right file? Was the string checked in recently? Did you manage to get a build with the externalized string in it? Can we close this? Yes, I can see the string externalized now. We can resolve this. Thanks! (In reply to Kit Lo from comment #5) > Yes, I can see the string externalized now. We can resolve this. Thanks! Thanks for reporting back Kit. Closing worksforme. |
Created attachment 244371 [details] Settings - JavaScript Validator.png JavaScript Validator - "Switch case fall-through:" unexternalized