Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 437300

Summary:	Code cleanup: Move functionality from searchResults.js into searchExplorer.js and delete file
Product:	[ECD] Orion	Reporter:	Elijah El-Haddad <elijahe>
Component:	Client	Assignee:	Elijah El-Haddad <elijahe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	6.0
Target Milestone:	6.0 RC3
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Elijah El-Haddad

2014-06-12 14:37:25 EDT

searchResults.js->SearchResultsGenerator only has 3 methods which would be best integrated into searchExplorer.js->SearchResultExplorer. This would enable the deletion of searchResults.js thereby reducing the already too large number of search related .js files in the client making the search code easier to understand and reuse. 

It would also have the added benefit of reducing the number of lines of code in the codebase while grouping related methods together in a way that is easier to understand and consume.

Comment 1 Elijah El-Haddad

2014-06-12 14:44:12 EDT

Pushed to eclipse.org:

- Moved useful functionality out of searchResults.js into searchExplorer.js
- Deleted searchResults.js
- Refactored methods to reduce duplication and improve readability/clarity of code

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=9026f8a24f6999ede2d6cf863ea64fa5aed02874