Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 437279

Summary: Delete AdvSearchOptContainer class and rename advSearchOptContainer.js
Product: [ECD] Orion Reporter: Elijah El-Haddad <elijahe>
Component: ClientAssignee: Elijah El-Haddad <elijahe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 6.0   
Target Milestone: 6.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Elijah El-Haddad CLA 2014-06-12 10:51:01 EDT 
The AdvSearchOptContainer class is no longer providing any functionality. All it currently does is instantiate a AdvSearchOptRenderer and call its render() function. That class should be deleted and the one caller, search.js, should be modified to instantiate a AdvSearchOptRenderer directly.

Finally, the file which contains both class definitions for AdvSearchOptContainer and AdvSearchOptRenderer is currently called advSearchOptContainer.js. Once AdvSearchOptContainer is deleted the file should be renamed to advSearchOptRenderer.js.
Comment 1 Elijah El-Haddad CLA 2014-06-12 10:59:44 EDT 
Pushed to eclipse.org

- Deleted AdvSearchOptContainer class and made search.js instantiate an AdvSearchOptRenderer directly
- Renamed advSearchOptContainer.js to advSearchOptRenderer.js
- Deleted unused .advSearchOptContainer CSS class from globalSearch.css

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=68e759e306409332d4f95cd3404b72e2db549949