Bugzilla – Full Text Bug Listing
| Summary: | update breadcrumbs for site_login | ||
|---|---|---|---|
| Product: | Community | Reporter: | Christopher Guindon <chris.guindon> |
| Component: | Website | Assignee: | phoenix.ui <phoenix.ui-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | denis.roy |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 432355 | ||
This is now live. I will need to open a new bug, the links are wrong. They go to www.eclipse.org instead of dev.eclipse.org. The home link is the only one that should link to www.eclipse.org Should we overwrite these in _projectCommon.php or something? Here's a fix for site_login. We define breadcrumbs in _projectCommon.php and attach those to $App->generatePage() https://git.eclipse.org/r/#/c/28650/ (In reply to Denis Roy from comment #4) > Here's a fix for site_login. We define breadcrumbs in _projectCommon.php > and attach those to $App->generatePage() > > https://git.eclipse.org/r/#/c/28650/ This wasn't working on the landing page since we were removing 2 levels of the breadcrumb. I submitted a new patch for this: https://git.eclipse.org/r/#/c/28650/ > This wasn't working on the landing page since we were removing 2 levels of > the breadcrumb. What landing page? > I submitted a new patch for this: > https://git.eclipse.org/r/#/c/28650/ What's the $allowed_domain_override for? You want to prevent altering breadcrumbs on dev.eclipse.org?
> > I submitted a new patch for this:
> > https://git.eclipse.org/r/#/c/28650/
>
What's the $allowed_domain_override for? You want to prevent altering
breadcrumbs on www.eclipse.org?
(In reply to Denis Roy from comment #6) > > This wasn't working on the landing page since we were removing 2 levels of > > the breadcrumb. > > What landing page? https://dev.eclipse.org/site_login/ When I checkout your patch, the only link that I had was home. > > > I submitted a new patch for this: > > https://git.eclipse.org/r/#/c/28650/ > > What's the $allowed_domain_override for? You want to prevent altering > breadcrumbs on dev.eclipse.org? No, it's a list of domain where we want to override www_prefix. We only need it for dev.eclipse.org but this give us some flexibility to add more domain if needs be. I will add a comment to explain $allowed_domain_override (In reply to Denis Roy from comment #7) > > > I submitted a new patch for this: > > > https://git.eclipse.org/r/#/c/28650/ > > > What's the $allowed_domain_override for? You want to prevent altering > breadcrumbs on www.eclipse.org? I am starting to think we don't need this now that I hardcoded the home link. Finally we do need it because $App->getWWWPrefix() will always return http://www.eclipse.org on dev.eclipse.org We cant update getWWWPrefix() because this will break all the links in the footer and in the main menu. (In reply to Christopher Guindon from comment #10) > Finally we do need it because $App->getWWWPrefix() will always return > http://www.eclipse.org on dev.eclipse.org > > We cant update getWWWPrefix() because this will break all the links in the > footer and in the main menu. I added a comment: https://git.eclipse.org/r/#/c/28650/12/eclipse.org-common/system/breadcrumbs.class.php (In reply to Christopher Guindon from comment #11) > (In reply to Christopher Guindon from comment #10) > > Finally we do need it because $App->getWWWPrefix() will always return > > http://www.eclipse.org on dev.eclipse.org > > > > We cant update getWWWPrefix() because this will break all the links in the > > footer and in the main menu. > > I added a comment: > > https://git.eclipse.org/r/#/c/28650/12/eclipse.org-common/system/breadcrumbs. > class.php I moved the patch to eclipse.org-common.git https://git.eclipse.org/r/28753 We are done here. |
The breadcrumbs on site login are wrong: Home Project site_login My Eclipse account It should be: Home My Account My Eclipse account