Bugzilla – Full Text Bug Listing
|
Description
Markus Keller
We did not had time to look at this problem in 4.6 Moving out Still reproducible with SWT master as of today, GTK3.22, and Fedora 28. New Gerrit change created: https://git.eclipse.org/r/126509 Gerrit change https://git.eclipse.org/r/126509 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9f91c882bb8f96c689143525a71937171402a3d7 (In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/126509 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=9f91c882bb8f96c689143525a71937171402a3d7 Patch is in master, thanks Xi. This seem to cause test issues, please investigate. I see that since a http://download.eclipse.org/eclipse/downloads/drops4/I20180808-2000/testResults.php, many UI tests started to fail on GTK3 builds. See most recent BAD build: http://download.eclipse.org/eclipse/downloads/drops4/I20180812-2000/testResults.php Last known good build: http://download.eclipse.org/eclipse/downloads/drops4/I20180807-2000/testResults.php I mean: 4 fails in e4.ui.bindings.tests 5 fails in ui.tests 3 fails in ui.workbench.texteditor.tests They complain about unexpected, inactive or missing windows: - "Application does not have an active window" - "expected:<Shell {MyWindow}> but was:<null>" - "expected:<org.eclipse.ui.internal.WorkbenchWindow@6efc419> but was:<org.eclipse.ui.internal.WorkbenchWindow@6af609ea>" - "this test does not work on GTK unless the runtime workbench has focus. Screenshot: /home/cbi/genie.releng/workspace/ep49I-unit-cen64-gtk3/workarea/I20180812-2000/eclipse-testing/results/ep49I-unit-cen64-gtk3_linux.gtk.x86_64_8.0/org.eclipse.ui.workbench.texteditor.tests.FindReplaceDialogTest.testFocusNotChangedWhenButtonMnemonicPressed.png" This must be reverted or fixed ASAP! 1 Open any text file 2 copy some text 3 Ctrl+F 4 Try to paste the text to search for via Ctrl+V into the text box: the text is pasted *into the editor*! New Gerrit change created: https://git.eclipse.org/r/127357 (In reply to Eclipse Genie from comment #8) > New Gerrit change created: https://git.eclipse.org/r/127357 We are in the process of investigating/fixing this. Please give us until the end of the day before reverting. (In reply to Eric Williams from comment #9) > (In reply to Eclipse Genie from comment #8) > > New Gerrit change created: https://git.eclipse.org/r/127357 > > We are in the process of investigating/fixing this. Please give us until the > end of the day before reverting. Perfect, thanks Eric. I wonted to have tomorrow build working :-) (In reply to Andrey Loskutov from comment #10) > Perfect, thanks Eric. I wonted to have tomorrow build working :-) No problem -- if no fix is found by end of day today, we'll revert. New Gerrit change created: https://git.eclipse.org/r/127364 Gerrit change https://git.eclipse.org/r/127357 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=b06158d7dd5b7576ae3250fd1c337625da5d2ee5 Gerrit change https://git.eclipse.org/r/127364 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ddc3826de4b8789f3df31a6927cb568b8e21c19f (In reply to Eclipse Genie from comment #14) > Gerrit change https://git.eclipse.org/r/127364 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=ddc3826de4b8789f3df31a6927cb568b8e21c19f Revised patch merged to master. New Gerrit change created: https://git.eclipse.org/r/127774 Verified in I20180821-2000. Gerrit change https://git.eclipse.org/r/127774 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ae69be6c3c1008e9517e8550424a0fd0d34b866d New Gerrit change created: https://git.eclipse.org/r/129713 I'm reopening this bug because the following commit changes org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell.test_activateEventSend() such that it can't be compiled on Windows: https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ae69be6c3c1008e9517e8550424a0fd0d34b866d It's of course better to use SwtTestUtil.isX11 as the guard because that is available on all platforms. (In reply to Ed Merks from comment #20) > I'm reopening this bug because the following commit changes > org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell.test_activateEventSend() > such that it can't be compiled on Windows: > > https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ae69be6c3c1008e9517e8550424a0fd0d34b866d > > > It's of course better to use SwtTestUtil.isX11 as the guard because that is > available on all platforms. Ed, would be better to have a new bug for that, so that the separate fixes can be distinguished (problem solved in 4.9) and test issue fixed in 4.10. (In reply to Eclipse Genie from comment #18) > Gerrit change https://git.eclipse.org/r/127774 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=ae69be6c3c1008e9517e8550424a0fd0d34b866d Hi Xi, Once a bug is marked verified against an already released version, we usually don't make further code commits. In this case, right practice would be to open a new bug for adding the new JUnit test. I suppose this should be closed again... (In reply to Niraj Modi from comment #23) > (In reply to Eclipse Genie from comment #18) > > Gerrit change https://git.eclipse.org/r/127774 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > > ?id=ae69be6c3c1008e9517e8550424a0fd0d34b866d > > Hi Xi, > Once a bug is marked verified against an already released version, we > usually don't make further code commits. In this case, right practice would > be to open a new bug for adding the new JUnit test. Hi Niraj, thanks for the info, and sorry about the trouble. Will keep it in mind next time! Verified in I20180923-1800. |