Bugzilla – Full Text Bug Listing
| Summary: | NPE importing projects with RC2 | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Laurent Goubet <laurent.goubet> |
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
| Status: | RESOLVED WORKSFORME | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bsd, daniel_megert, Lars.Vogel, pwebster |
| Version: | 4.4 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows NT | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 436358 | ||
|
Description
Laurent Goubet
Re-assigning. I did not manage to reproduce this, and looking at the code, it seems like the AccumulatingProgressMonitor is missing a "synchronized" on setTaskName since it is the only access to the "collector" field that's not protected. (In reply to Laurent Goubet from comment #1) > Re-assigning. I did not manage to reproduce this, and looking at the code, > it seems like the AccumulatingProgressMonitor is missing a "synchronized" on > setTaskName since it is the only access to the "collector" field that's not > protected. It was until M7. The fix for bug 432826 introduced this bug. Paul, this is something we might consider for RC4. I'm unable to reproduce this with my testing. Unlike bug 436356, this bug seems more sporadic. (In reply to Brian de Alwis from comment #4) > I'm unable to reproduce this with my testing. I have only had this pop once, though that was only after minutes of testing the RC3. Seems a little dangerous because of its location though, since it may create random error popups from anything that uses IWorkspaceRunnables. I've been able to reproduce this by using the "Import projects…" from the Git Repositories view and hammering on the "Search" button from the Add Local Git Repositories wizard. Can't reproduce when running the fix for bug 436358. !ENTRY org.eclipse.egit.core 4 0 2014-06-02 15:51:50.624 !MESSAGE !STACK 0 java.lang.NullPointerException at org.eclipse.jface.operation.AccumulatingProgressMonitor.setTaskName(AccumulatingProgressMonitor.java:206) at org.eclipse.egit.ui.internal.repository.RepositorySearchDialog.findGitDirsRecursive(RepositorySearchDialog.java:420) at org.eclipse.egit.ui.internal.repository.RepositorySearchDialog.access$10(RepositorySearchDialog.java:386) at org.eclipse.egit.ui.internal.repository.RepositorySearchDialog$10.run(RepositorySearchDialog.java:467) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122) (In reply to Brian de Alwis from comment #6) > I've been able to reproduce this by using the "Import projects…" from the > Git Repositories view and hammering on the "Search" button from the Add > Local Git Repositories wizard. Can't reproduce when running the fix for bug > 436358. That's a bit unclear: I've found a different way to reliably reproduce an NPE that occurs for a similar reason. It's not the same execution path. Laurent, we think we've fixed this in RC4. Could you please re-test? PW (In reply to Paul Webster from comment #8) > Laurent, we think we've fixed this in RC4. Could you please re-test? I have, and couldn't reproduce this. It was already a very rare occurence before the fix, though. Anyway, even using Brian's method from comment c6 didn't allow me to reproduce the issue with RC4. (In reply to Laurent Goubet from comment #9) > (In reply to Paul Webster from comment #8) > > Laurent, we think we've fixed this in RC4. Could you please re-test? > > I have, and couldn't reproduce this. It was already a very rare occurence > before the fix, though. Anyway, even using Brian's method from comment c6 > didn't allow me to reproduce the issue with RC4. Thanks Laurent for validating. Marking as WORKFORME, even though this was actually FIXED, I don't have a commit to point to and in this case I prefer the other status. |