Bugzilla – Full Text Bug Listing
| Summary: | buildnotes are no longer collected | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | Releng | Assignee: | David Williams <david_williams> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | daniel_megert |
| Version: | 4.4 | ||
| Target Milestone: | 4.6 M7 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=468391 | ||
| Whiteboard: | |||
|
Description
David Williams
As a side note, I discovered one bundle has an apparently old "buildnotes" file and opened bug 436301 for that. The fix for this looks fairly simply .. but may be a "change in procedure" ... Currently there is a place in the "generate test results summaries" that does it, but does not copy from correct "location" (it's assuming old PDE build structure). AND there is a place in the normal publishing "helper.xml" script that does it, but everything except "making the directory" has been commented out. I do notice there, though, that "css" files are also copied, at least, one is: jdt_core_style.css. And that doesn't seem right. We should use a common style, IMHO ... wrapping these html files in the "Eclipse style" (see bug 436282). (In reply to David Williams from comment #1) > As a side note, I discovered one bundle has an apparently old "buildnotes" > file and opened bug 436301 for that. That bundle is not part of our build. honestly don't recall where this one stands ... but, don't believe anyone uses them at the moment, so lowering proorty. This might actually be fixed. But will need to investigate and/or just "try it out" some time to determine. To determine if this is still a bug, I have committed a "buildnote". http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=7d807df1b170d4a424dfe7a3539c3dd32281edef It will be reverted once that is determined. I have determined this is still a bug. PLUS, I have noticed the "old" astview buildnotes are still checked out from master, and hence, would show up on the DL page, if left. It is good that astview was removed as a module, and I see from bug 436301 that is is desired not to remove from the master branch, but can its old buildnotes_astview.html file be removed? (In reply to David Williams from comment #6) > but can its old buildnotes_astview.html file be removed? Done with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=4c139dbda91d33ec92059b75631070df0678327e Fixed to my satisfaction. It was actually "in" last night's build. See http://download.eclipse.org/eclipse/downloads/drops4/N20160414-2000/ But was at the bottom of the "related links" section (not visible if simply looking at the page without scrolling). Plus, if clicked, it and any notes clicked would produce the plainest HTMl display. So, I wrapped both with a little "solstice theme" look and put the link at the top of the "Tests and Logs" list of links. Under the assumption if there is a "build note" of any sort, it should be important enough for all to read. If that assumption is wrong, or is even more important, then we can devise other strategies. Since no one seems to miss having these, I think is suffices to say we have the function, but I do not plan to encourage people to use it. We should use it though, if there is a bad, known problem or change (such as "due to bug xxx you can not import projects with this build". I did also update the wiki at https://wiki.eclipse.org/Platform-releng/Platform_Build_Automated#Build_Notes just to clarify things have changed a little since the old method. (For example, we no longer gather *.htm files (just *.html) and we do not gather *.css files as we did in the past. Changes in styling should be done in a way coordinated with releng via our normal templates and wrappers.) I also will remove some old code in some "publish" and "helper" tasks, since we now gather any files much earlier since we gather them directly from the gitcache on the build machine. Verified that the N20160415-2000 build has my "test build note" and all looks and behaves as expected. http://download.eclipse.org/eclipse/downloads/drops4/N20160415-2000/ So, will now remove my "test build note" from 'releng bundle'. And then the list item should no longer appear in the next build. |