Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 436215

Summary: Create a reusable combo text input box component
Product: [ECD] Orion Reporter: Elijah El-Haddad <elijahe>
Component: ClientAssignee: Elijah El-Haddad <elijahe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 6.0   
Target Milestone: 7.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Elijah El-Haddad CLA 2014-05-29 18:37:37 EDT
The purpose of this bug is to track the work required to create a reusable ComboTextInput component. This component will be composed of HTML, JS and CSS files.

The resulting HTML element will be composed of a text input box, combined with optional input completion and an attached <button>.
Comment 1 Elijah El-Haddad CLA 2014-06-02 16:51:54 EDT
Pushed the following to eclipse.org master:

- Initial implementation of ComboTextInput
- Replaced search and replaced boxes of the global search page with instances of ComboTextInput
- Deleted all recent search related code from searchUtils.js
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5c1e1e6cd37eb7bdbec0d9d688e779b73e94f32c

- Deleted dead code from advSearchOptContainer.js
- Deleted unnecessary combo text input button wrapper span
- Fixed recent entry deletion in ComboTextInput.js
- Prevented addition of empty or duplicate entries to recent entry list in ComboTextInput.js
- Moved logic to show/hide button into ComboTextInput.js
- Fixed minor bug which was preventing replace wrapper div from being completely removed from html flow when hidden
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fcb4c701a5ea75c2a02bd7e7c96f763995e83ce0

- Replaced file name patterns input field with an instance of ComboTextInput which will remember recent entries
- Added docs to ComboTextInput.js
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d4551a8411ce4915e932e9a082ad93a3332e9563
Comment 2 Elijah El-Haddad CLA 2014-06-12 10:59:05 EDT
- Made recent entry button (down arrow) only appear next to text input box if there are recent entries saved
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=34aae73a3d39387840e5f989a4d4ec356e30abb8
Comment 3 Elijah El-Haddad CLA 2014-08-28 15:24:11 EDT
Resolving this bug as fixed. Further improvements should be covered by new bugs.