Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 436197

Summary:	Don't try to start GNOME metacity window manager on KDE when doing automated performance tests
Product:	[Eclipse Project] Platform	Reporter:	Matthias Mailänder <matthias.mailaender>
Component:	Releng	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	david_williams
Version:	4.4
Target Milestone:	4.4
Hardware:	PC
OS:	Linux
Whiteboard:	routine releng

Description Matthias Mailänder

2014-05-29 12:52:29 EDT

Bug 379026 introduced a check for various window managers. http://techbase.kde.org/Projects/KWin is missing. Will send a patch.

Comment 1 Matthias Mailänder

2014-05-29 13:15:55 EDT

https://git.eclipse.org/r/27548

Comment 2 David Williams

2014-05-29 13:27:19 EDT

This should be perfectly safe fix, even for RC4 ... and ... if it helps get performance tests running, I think it's worth putting RC4.

Comment 3 David Williams

2014-05-30 03:40:11 EDT

Looking at this again, I see you changed the version in 

.../eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/src/main/scripts/runtests.sh

But there is another version in 

.../production/testScripts/configuration/sdk.tests/testScripts/runtests.sh

They are (probably identical) ... and some day we may get rid of the one in "production" ... but in our experience has been that it is very convenient (if not necessary) to be able to make quick/easy changes ... say, to "re-run" the tests, without doing a "rebuild". 

So, more work to do here. Please make sure the parallel files stay the same.

Comment 4 Matthias Mailänder

2014-05-30 04:12:59 EDT

Those test scripts were outside of the Eclipse workspace so its file search only gave me one one occurrence. See https://git.eclipse.org/r/27569 for a followup. It also adds it to the triple check forgot about, too.

Comment 5 David Williams

2014-05-30 08:30:58 EDT

(In reply to Matthias Mailänder from comment #4)
> Those test scripts were outside of the Eclipse workspace ... 

You mean your workspace, right? I always import 
eclipse.platform.releng.aggregator
(but, usually not it's "submodules" since that'd be redundant ... with the way I do my workspace -- but, sometimes do submodules too, if I just want "all the code".). There is a script, in 
eclipse.platform.releng.aggregator/devutils/submodule_pull.sh
that can help "get what you need" ... but read it carefully, might need some adjustment.

Comment 6 Matthias Mailänder

2014-05-30 08:37:27 EDT

Yes, I did not fetch the sub-module content as I don't have the bandwidth and storage capacity for it. We use https://build.vogella.com/ci/view/Performance/job/C-MASTER-eclipse.platform.releng.aggregator/ to do the job for us and cache the result. I downloaded that Jenkins workspace for debugging yesterday and it turned out to be 20 GB.

Comment 7 David Williams

2014-06-10 13:00:03 EDT

I put the "kwin" check in production version of runtest.sh and committed to master ... but won't bother "tagging" it as R4_4 (once we do that). 

Would have preferred to have gotten a patch, for this to be a "complete fix", but, trying to get all "4.4" but off the list. 

FWIW, I also opened but 437069 to track other cleanup that needs to happen in these files. 

Also, for what its worth, I think if Hudson has Xvnc set up correctly, that no window manager needs to be started ... but I did search bugs for where we've had trouble with no window manager running, in the past: see bug 401307 and bug 379026.