Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 436086

Summary:	Allow filtering on generated settings pages
Product:	[ECD] Orion	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	Client	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public, john.arthorne, Michael_Rennie
Version:	6.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	430131, 444191, 444998
Bug Blocks:

Description Curtis Windatt

2014-05-28 12:08:18 EDT

Cloned to do more advanced changes such as providing filtering.

+++ This bug was initially created as a clone of Bug #430131 +++

We should provide our own preference page so that we can better categorize the linting options. I envision it having:

1. collapsible sections
2. filter box at the top
3. restore defaults button

Comment 1 John Arthorne

2014-05-30 13:59:58 EDT

Some comments on the current appearance: There is now a huge empty space on the left hand side (1). Also, the drop-downs no longer align on the right hand side which looks very choppy (2). This needs some visual polish. Numbers refer to screenshot in bug 430131.

Comment 2 Curtis Windatt

2014-06-02 10:46:24 EDT

(In reply to John Arthorne from comment #1)
> Some comments on the current appearance: There is now a huge empty space on
> the left hand side (1). Also, the drop-downs no longer align on the right
> hand side which looks very choppy (2). This needs some visual polish.
> Numbers refer to screenshot in bug 430131.

(1) The empty space on the lefthand side matches all the other settings page.  I agree that it is wasted space, but currently the generated settings have no sub-categories.  Compare to the Git Settings, where they have sub-categories.

(2) This has not changed with my fix.  It has a hard coded percentage min width (20% I believe).  The validation page has long text which is a problem.  If I change the CSS values it will change all of the pages (including non generated pages such as the Editor settings).  When experimenting, increasing the percentage min width improves the validation page significantly, but increasing it very much makes the editor page worse.

Comment 3 Curtis Windatt

2014-06-02 16:57:28 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f5a30662e0aeb928e3b8011f3e5535349a80b18d

This removes the empty header space, less consistent with the other pages, but removes the useless whitespace.

This change also alters the width settings for all the settings pages.  Now when you shrink the page down it can use the remaining whitespace far more effectively. This is a huge improvement for Firefox and a decent improvement for Chrome (both in Windows).  It would be good to get feedback for other platforms.

Comment 4 Curtis Windatt

2015-12-03 12:04:42 EST

Collapsible sections and restore defaults are both implemented now. Renaming this bug for the remaining bug item, filtering the page.

Comment 5 Michael Rennie

2017-01-10 15:43:25 EST

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04002.html