Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 436073

Summary: wrong application exit code in case of exception
Product: [Eclipse Project] Equinox Reporter: Igor Fedorenko <igor>
Component: FrameworkAssignee: Thomas Watson <tjwatson>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: irbull, mistria, pascal, t-oberlies, tjwatson
Version: 3.10.0 LunaFlags: irbull: review+
tjwatson: review? (pascal)
Target Milestone: Luna RC3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 436042    

Description Igor Fedorenko CLA 2014-05-28 10:49:43 EDT 
I believe this is the root cause of tycho bug 436042. When eclipse application execution fails with exception, Equinox JVM still returns exit code 0.

The problem was introduced in Luna and from what I can tell org.eclipse.equinox.launcher.Main (still?) checks PROP_EXITCODE system property, while EclipseStarter#setProperty uses some other map. Using -Dosgi.framework.useSystemProperties=true does not make a difference.
Comment 1 Igor Fedorenko CLA 2014-05-28 10:52:42 EDT 
Given the impact this bug has on Tycho users, i.e. Tycho misses failures and errors in all UI-based tests run against Luna, I think this is critical and should be looked at for Luna.
Comment 2 Thomas Watson CLA 2014-05-28 15:30:08 EDT 
I agree, should look at for Luna.
Comment 3 Thomas Watson CLA 2014-05-28 16:32:44 EDT 
Possible fix under review:

https://git.eclipse.org/r/#/c/27503/
Comment 5 Ian Bull CLA 2014-05-28 22:44:57 EDT 
I gave the +1 on gerrit. I guess it needs to be here too.
Comment 6 Thomas Watson CLA 2014-05-29 11:42:54 EDT 
Verified on I20140528-2000
Comment 7 Igor Fedorenko CLA 2014-05-31 09:30:56 EDT 
*** Bug 436042 has been marked as a duplicate of this bug. ***
Comment 8 Tobias Oberlies CLA 2014-07-14 09:06:26 EDT 
*** Bug 434648 has been marked as a duplicate of this bug. ***