Bugzilla – Full Text Bug Listing
| Summary: | iOS toolkit - new action "UITabBar - check badge value" | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] Jubula | Reporter: | Kiss Tamás <tamas.kiss> | ||||||||||||
| Component: | RC | Assignee: | Kiss Tamás <tamas.kiss> | ||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Oliver Goetz <Oliver.Goetz> | ||||||||||||
| Severity: | enhancement | ||||||||||||||
| Priority: | P3 | CC: | Maissmaallsmyss.Maulhs, markus.tiede | ||||||||||||
| Version: | unspecified | ||||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | Mac OS X | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 437162 | ||||||||||||||
| Attachments: |
|
||||||||||||||
This contribution complies with http://www.eclipse.org/legal/CoO.php Comment on attachment 243623 [details] Badge value patch file This contribution complies with http://www.eclipse.org/legal/CoO.php Patch has been applied with http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=6bd5493fe446aafa0ac4a99704fd1d752c365ba4 We've just noticed that the action lacks of an operator for the badge values string comparison - @TKi: Could you please fix this and provide a small patch to address this? As discussed with TK, badge value can only be a number and though it is implemented as a string on Apple´s side, we decided to have an integer parameter in Jubula not to confuse users. I just checked the badge value and I realised the Integer value is won't be good, because this badge value can any string. That's why I will remain string and will add the operator parameter. Created attachment 244733 [details] Badge value patch file - Change the name to "Check Badge Value". - Add operator to check badge value string. This contribution complies with http://www.eclipse.org/legal/CoO.php This patch (attachment 244733 [details]) has not been created from a commit - please do so so that we can maintain the correct author information. Thanks!
Created attachment 244735 [details] Badge value patch file Patch created from commit - Change the name to "Check Badge Value". - Add operator to check badge value string. This contribution complies with http://www.eclipse.org/legal/CoO.php Patch has been applied with http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=257344502be93626bb5fccf55adf581b5e638de9 Fix the operator parameter: https://bitbucket.org/jubula/com.bredexsw.jubula.core/commits/0da0ae7a96e6b0a8f32d5e0b69bc78c41d5f7e5b?at=master Created attachment 244854 [details] Remove default value from operator param Provide patch file to remove default value from operator parameter This contribution complies with http://www.eclipse.org/legal/CoO.php Tamas, thanks for contributions! I´ve noticed that in case of not existing badge we have an action error with description "action error". Maybe it would be better to have some more detailed description, e.g. "Badge value does not exist", similar to a description that you have made for wrong index "Action Error: invalid index"? Everything else looks good. Change the error message when there is no badge value. And I also changed the actual value and expected value https://bitbucket.org/jubula/com.bredexsw.jubula.core/commits/474fcc41ca5539f288763aad1a879e083393b123 Created attachment 244911 [details]
Test results for check badge value - work as expected
I´ve tested that now for no present badge we have correct description and also Pattern and Actual values are in right fields of Properties View.
Closed due to comments 14 and 15 |
Created attachment 243623 [details] Badge value patch file add check badge value method to component xml and I18nStrings patch file.