Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 435991

Summary: Explorer options should have more control over highlighting (mouse hover or alternating light/dark)
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: ClientAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 6.0   
Target Milestone: 6.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Curtis Windatt CLA 2014-05-27 17:47:47 EDT 
Tables such as the validation settings page set the noSelection option to true on the Explorer as they do not intend for the user to select items at all.  However, there is still a css class set to change colour when hovering.

This is annoying on the settings pages because multiple settings are included on the row, but the entire row is highlighted.

While the options are internal, we can check getNavDict() as no NavDict will be created if noSelection is on.  This check will still allow tables that allow selection to have highlighting (see many of the Git tables) and tables that have a limited selection policy, but don't set the noSelection option (see Git branches table where no selection is allowed, but highlighting remains).
Comment 1 Curtis Windatt CLA 2014-05-27 17:55:04 EDT 
This may become unecessary, depending on changes in Bug 430131
Comment 2 Curtis Windatt CLA 2014-05-28 11:51:25 EDT 
Making two changes as part of this bug, both in explorer.js.

1) noSelection option will now turn off the 'selectableNavRow' class which provides a highlight on hover action.  This effect could be done using the 'cursorOnly' selection policy, but noSelection prevents the use of a selection policy.

2) A new option on the ExplorerRenderer, noRowHighlighting, will be added that will turn off the light/dark css classes on alternating rows.  Some tables avoid the colouring by providing their own row renderer, but an option is a much simpler fix for tables such as PluginSettings.