Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 435810

Summary:

PDE Manifest editor: Missing 2.0 compatibility should be shown as error

Product:

[Eclipse Project] PDE

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

Vikas Chandra <Vikas.Chandra>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, Michael_Rennie

Version:

4.4

Flags:

daniel_megert: review+
curtis.windatt.public: review+
Michael_Rennie: review+

Target Milestone:

4.4 RC3

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

421979

Bug Blocks:

Attachments:

Description	Flags
Fix to solve the issues	none
Simpler Fix	none

Description Dani Megert

2014-05-26 12:10:44 EDT

4.4 RC2.

FUP of bug 421979.

My test case always imported one of my demo bundles from CVS and then I replaced it with a version that did not have a manifest. Unfortunately, PDE can populate the PDE container during the initial import and then keeps it after replace. However, if one closes and reopens the project, or directly imports a 2.0 style bundle, then the PDE container won't resolve and the project stays full of errors. Hence, we should show an error when the compatibility bundle isn't installed and the message should say "to compile or run".

Comment 1 Dani Megert

2014-05-26 12:13:18 EDT

Vikas, please prepare a patch for RC3.

Comment 2 Vikas Chandra

2014-05-27 06:16:41 EDT

Created attachment 243524 [details]
Fix to solve the issues

1) Now "error mark" ( instead of "warning mark") for this message for PLUGIN OR FRAGMENT 

You must either manually create an OSGi bundle manifest or install the 'Eclipse 2.0 Style Plugin Support'</a> from 'The Eclipse Project Updates' software site to compile or run this plug-in. ( or fragment)


2) "to compile or run this plug-in" INSTEAD OF  "to run this plug-in" ( Or fragment).


2 person need to approve this before it can be commited

Comment 3 Dani Megert

2014-05-27 06:33:29 EDT

Created attachment 243526 [details]
Simpler Fix

The first fix works, but for RC3 there's a fix with less changes in the code: just add the error image:

warningText.setImage("error", lp.get(PDEPluginImages.DESC_ERROR_ST_OBJ, 0)); //$NON-NLS-1$

Comment 4 Curtis Windatt

2014-05-27 10:19:22 EDT

+1 for RC3

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6a7a76406eab204a3f55dd2d98e1fa26e15faa81
Pushed to master

Change announced to the mailing list.

Comment 5 Dani Megert

2014-05-29 05:32:44 EDT

Verified in I20140528-2000.