Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 435721

Summary:	[CSS][Dark] Provide resonable defaults for syntax color of Debug views in Dark theme
Product:	[Eclipse Project] Platform	Reporter:	Andrea Guarinoni <andrea.guarinoni>
Component:	Debug	Assignee:	Andrea Guarinoni <andrea.guarinoni>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	andrea.guarinoni, curtis.windatt.public, daniel_megert, Michael_Rennie, sarika.sinha
Version:	4.4	Flags:	Michael_Rennie: review+ daniel_megert: review+ sarika.sinha: review+ curtis.windatt.public: review+
Target Milestone:	4.4 RC3
Hardware:	PC
OS:	All
Whiteboard:

Description Andrea Guarinoni

2014-05-25 17:08:10 EDT

Eclipse Luna allows that project can contribute styling to existing themes.
Would be great if Debug tools like Console can provide a suitable integration with the Dark theme.

More details can be found in Bug 433475.

Comment 1 Andrea Guarinoni

2014-05-25 17:20:17 EDT

The patch proposal for the issue:
https://git.eclipse.org/r/27248

Comment 2 Sarika Sinha

2014-05-26 07:01:09 EDT

(In reply to Andrea Guarinoni from comment #1)
> The patch proposal for the issue:
> https://git.eclipse.org/r/27248

Bundle-version range should be added for org.eclipse.e4.ui.css.swt.theme

Comment 3 Andrea Guarinoni

2014-05-26 10:48:04 EDT

(In reply to Sarika Sinha from comment #2)
> (In reply to Andrea Guarinoni from comment #1)
> > The patch proposal for the issue:
> > https://git.eclipse.org/r/27248
> 
> Bundle-version range should be added for org.eclipse.e4.ui.css.swt.theme

[0.9.0, 1.0.0) would be fine?

(current version in Luna is 0.9.300, Kepler was 0.9.100, by the way on old bundles the loading of this stylesheet should fail with no issues)

Comment 4 Dani Megert

2014-05-27 15:22:09 EDT

Let's squeeze this in for 4.4.

Comment 5 Curtis Windatt

2014-05-27 16:01:31 EDT

+1
Improves the console significantly.  The value changed colours match the theme a little better.  The memory view changes look good from the preference page, but I don't have a memory view example to verify on.

Comment 6 Sarika Sinha

2014-05-28 03:58:39 EDT

+1
Looks better.

Comment 7 Dani Megert

2014-05-28 04:12:04 EDT

I've pushed a new patch set where I removed the dependency on org.eclipse.e4.ui.css.swt.theme. This is not necessary, since all Debug functionality works fine without that bundle. Otherwise, the previous patch set looked good.

Comment 8 Dani Megert

2014-05-28 05:36:56 EDT

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=2b472ac6c5dc8eb0f92c3aef321949ba3e0f7014

Comment 9 Dani Megert

2014-05-29 05:50:12 EDT

The "css" entry in the 'build.properties' file was missing a '/' and hence the style sheet is not part of the latest build (I20140528-2000). The copyright date was also not updated.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=0c37e2adf59b6ddad7779f2cff64e361218dafe1

Comment 10 Dani Megert

2014-05-31 03:40:34 EDT

Verified in I20140530-2000.