Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 435512

Summary: [CSS] Override the preferences customized by the user with the proper CSS values
Product: [Eclipse Project] Platform Reporter: Daniel Rolka <daniel.rolka>
Component: UIAssignee: Daniel Rolka <daniel.rolka>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, Lars.Vogel, markus.kell.r
Version: 4.4   
Target Milestone: 4.5 M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Daniel Rolka CLA 2014-05-22 08:33:22 EDT
When we switch the CSS theme we should override all preferences customized by the user that are restyled in the new CSS theme
Comment 1 Daniel Rolka CLA 2014-05-22 08:45:42 EDT
However the user still should be able to customize the preference values overridden by the CSS
Comment 2 Daniel Rolka CLA 2014-05-22 09:09:16 EDT
(In reply to Daniel Rolka from comment #1)
> However the user still should be able to customize the preference values
> overridden by the CSS

It works in this way now, but I mentioned about it just to keep it in mind

Daniel
Comment 3 Paul Webster CLA 2014-05-22 09:10:28 EDT
Here's a concrete test script:

1) create a project with some java classes

2) Preferences>Java>Editor>Syntax Coloring ... Java>Classes.  Change it to some other color, like Green and apply.  Colors change.

3) Preferences>General>Appearance and switch to the Dark theme

Result:  The classes colors should be set to the dark theme class colors

4) Preferences>Java>Editor>Syntax Coloring ... Java>Classes.  Change it to some other color, like Green and apply.  Colors change.

6) restart.

Result: the classes color stays green.

PW
Comment 4 Daniel Rolka CLA 2014-05-22 09:13:27 EDT
(In reply to Daniel Rolka from comment #0)
> When we switch the CSS theme we should override all preferences customized
> by the user that are restyled in the new CSS theme

Currently the user has to manually reset preferences in order to expose it for the CSS engine, either by using the 'reset to default' button or removing the entry from the proper property file

Daniel
Comment 6 Daniel Rolka CLA 2014-10-30 11:44:09 EDT
Verified in the build I20141026-2100

Daniel