Bug 435436

Description Damon S 2014-05-21 15:05:34 EDT

Created attachment 243365 [details]
The modified source code which includes our fixes

In our product, we have a (dojo) widget which creates an instance of the Orion editor (http://download.eclipse.org/orion/drops/R-4.0-201310301703/download.php?dropFile=built-editor.js) and then provides its own content assist, and other functionalities (specific to our product).

During the course of development, we encountered the following issues with the Orion editor code. Please note that these issues 1 and 3 may be specific to our product which has a complex UI (with tabs, content panes, UI elements being displayed at specific times, etc.). Issue 2 may not be really a defect but just a requirement for our product even though I think it would be good to have that functionality in Orion. We were not able to observe these issues in the Orion demos. Nonetheless, we did encounter them time and again in our product.

1. In Firefox, after a call to setText method, hitting backspace button would cause exceptions (in the console) and content assist stops working.
2. When editor is in single line mode, hitting tab inserts a tab; we want to be able to tab out to the next element (our product specification).
3. When content assist list is too long, using the up and down keys on the keyboard to navigate through the list causes a change in the layout. (In our development cycle, we had some items disappear from the UI).

We have made some minor changes to the Orion editor source code (http://download.eclipse.org/orion/drops/R-4.0-201310301703/download.php?dropFile=built-editor.js) to either enhance the functionality to fit the needs of our product or to safeguard against specific situations which may lead to exceptions or layout problems. The fixes solved the problems we had and so I am attaching that source code to this defect in case anyone else finds it helpful. The changes are marked in CHANGE START and CHANGE END comments.

Note that the Orion editor source code was also modified to remove some of the unneeded functions (for our product) such as the initial require and almond components as well as the editor instantiation code.