Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 434991

Summary:	[QuickAccess] Ctrl+3 quick access popup, while search field is hidden, does not use the correct scope
Product:	[Eclipse Project] Platform	Reporter:	Noopur Gupta <noopur_gupta>
Component:	UI	Assignee:	Paul Webster <pwebster>
Status:	VERIFIED FIXED	QA Contact:	Daniel Rolka <daniel.rolka>
Severity:	major
Priority:	P3	CC:	bsd, daniel_megert, Lars.Vogel, Rene.Brandstetter, sudol.wojciech
Version:	4.4	Flags:	bsd: review+ daniel.rolka: review+
Target Milestone:	4.4 RC3
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=535679
Whiteboard:

Description Noopur Gupta

2014-05-15 12:34:49 EDT

Luna 4.4 M7 I20140501-0200.

- Hide quick access search field or hide the toolbar.
- Press Ctrl+3. The quick access popup will appear.
- Type something, say "tool". Some entries will be shown, with the message "Press Ctrl+3 to show all matches" at the bottom.
- Press Ctrl+3 => Nothing happens.
- Try the same in quick access search field after restoring it and it works there.

Also, in the popup, "Previous Choices" are not shown in the result most of the times. It shows up after typing most of the characters required for the search.

Comment 1 Dani Megert

2014-05-19 05:43:18 EDT

This is a regression compared to 4.3.x.

Comment 2 Dani Megert

2014-05-19 05:50:32 EDT

Looks like the scope is not correctly set: if I invoke the popup while in the editor, none of the editor commands are shown.

Comment 3 Paul Webster

2014-05-28 11:30:45 EDT

Fix available with https://git.eclipse.org/r/27471

PW

Comment 4 Lars Vogel

2014-05-28 14:06:58 EDT

(In reply to Paul Webster from comment #3)
> Fix available with https://git.eclipse.org/r/27471
> 
> PW

Thanks Paul for the fix. I can confirm that the fix solves comment 2. The "press Ctrl+3 again" issue from comment 1 is not solved AFAICS. Hard to tell if the fix targets both issues or only the one from Dani.

Comment 5 Paul Webster

2014-05-28 14:13:49 EDT

(In reply to Lars Vogel from comment #4)
> Thanks Paul for the fix. I can confirm that the fix solves comment 2. The
> "press Ctrl+3 again" issue from comment 1 is not solved AFAICS. Hard to tell
> if the fix targets both issues or only the one from Dani.

This fix targets that you can't use editor commands in the popup when in an editor (the scope problem).  I feel that's the more serious problem.

I didn't look into hitting CTRL+3 twice.

PW

Comment 6 Paul Webster

2014-05-28 15:00:00 EDT

Turns out the CTRL+3 fix was trivial, so I added it.

Lars, Brian, could you please review?

PW

Comment 7 Paul Webster

2014-05-28 15:48:10 EDT

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=87b0c10b81c0ebfa0d44ded0b9cf51c628e9c916

PW

Comment 8 Dani Megert

2014-05-29 05:30:27 EDT

Verified in I20140528-2000.