Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 434894

Summary: [Theming][Table] text-decoration CSS property on TableItem not working in Chrome and IE
Product: [RT] RAP Reporter: Benjamin Wolff <eclipse>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tbuschto
Version: 2.3   
Target Milestone: 2.3 RC1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
text-decoration property added to the wrong div none

Description Benjamin Wolff CLA 2014-05-14 14:50:30 EDT
Created attachment 243098 [details]
text-decoration property added to the wrong div

When using a the 'text-decoration' property on the TableItem in a custom theme, this property doesn't seem to have any effect in Chrome and IE, yet it seems to work in FF.

For example, using it in a widget variant like this:

TableItem.inaktiv {
    text-decoration: line-through;
}

When setting this widget variant to the TableItem object, the result will be that the text-decoration is not applied on the text content of the TableItem in Chrome (34.0.1847.131) or IE11. It works in FF (29) though.

It looks like the problem is that the text-decoration property is applied to a div that has a nested div that contains the actual text content (see attached screenshot). The text-decoration property is not inherited, so Chrome and IE probably produce the correct result by showing an unchanged text (with no decoration).

Possible solutions would be to apply the CSS property on the nested div that holds the text, if possible, or set 'text-decoration=inherit' on it to have it inherited from the parents. Both solutions work in Chrome and IE when manually adding the property to the inline style in the browser.

Cheers,
Ben
Comment 1 Benjamin Wolff CLA 2014-05-15 04:31:58 EDT
I did not verify it, but this issue might also apply to other items that also supportch also text-decoration property, like TreeItem, Combo-List-Item, CCombo-List-Item, DropDown-Item, Label, ...

It's probably worth checking.

Cheers,
Ben
Comment 2 Ivan Furnadjiev CLA 2014-05-15 04:34:44 EDT
Pending change https://git.eclipse.org/r/26557, which will fix the issue in Tree/Table/(C)Combo-List-Item and DropDown-Item.
Comment 3 Benjamin Wolff CLA 2014-05-15 04:44:27 EDT
Awesome! Code review looks good to me.

Is there a chance it can make it into 2.3 RC1?

Thanks a lot!

Cheers,
Ben
Comment 4 Ivan Furnadjiev CLA 2014-05-15 04:54:06 EDT
(In reply to comment #3)
> Is there a chance it can make it into 2.3 RC1?
This is the idea ;-)
Comment 5 Ivan Furnadjiev CLA 2014-05-15 09:04:44 EDT
Merge change https://git.eclipse.org/r/26557 to master.