Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 434448

Summary: Add Gerrit help to the generated contribution guide
Product: Community Reporter: Wayne Beaton <wayne.beaton>
Component: ProcessAssignee: Portal Bugzilla Dummy Inbox <portal-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
URL: http://www.eclipse.org/projects/tools/default_contributing_file.php?id=technology.paho
Whiteboard: stalebug

Description Wayne Beaton CLA 2014-05-08 14:36:58 EDT
Paho has made some nice additions to the automatically-generated contributing guide; especially with regard to Gerrit (the "Source" section is also quite nice).

http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.python.git/tree/CONTRIBUTING.md

Consider adding this content or something like it.
Comment 1 Eclipse Genie CLA 2016-04-28 17:45:20 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Eclipse Genie CLA 2018-04-19 19:09:36 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Wayne Beaton CLA 2018-04-20 12:30:43 EDT
(In reply to Wayne Beaton from comment #0)
> http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.python.git/tree/
> CONTRIBUTING.md

Paho moved to GitHub, but the cited content is still in the history:

Contributing a patch
--------------------

The Paho repositories are accessed through Gerrit, the code review
project, which makes it possible for anybody to clone the repository, make
changes and push them back for review and eventual acceptance into the project.

To do this, you must follow a few steps. The first of these are described at

- https://wiki.eclipse.org/Development_Resources/Contributing_via_Git

* Sign the Eclipse CLA
* Use a valid commit record, including a signed-off-by entry.

There are further details at

- https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions

Once the patch is pushed back to Gerrit, the project committers will be
informed and they will undertake a review of the code. The patch may need
modifying for some reason. In order to make amending commits more
straightforward, the steps at
https://git.eclipse.org/r/Documentation/cmd-hook-commit-msg.html should be
followed. This automatically inserts a "Change-Id" entry to your commit message
which allows you to amend commits and have Gerrit track them as the same
change.

What happens next depends on the content of the patch. If it is 100% authored
by the contributor and is less than 250 lines (and meets the needs of the
project), then it can be committed to the main repository. If not, more steps
are required. These are detailed in the legal process poster:

- http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
Comment 4 Eclipse Genie CLA 2020-04-10 07:57:07 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.